Skip to content

Commit 309d140

Browse files
committed
[mlir] Simplify unreachable type switch cases. NFC.
Use `DefaultUnreachable` from llvm#161970.
1 parent 3149a77 commit 309d140

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ static void getTreePredicates(std::vector<PositionalPredicate> &predList,
243243
.Case<OperandPosition, OperandGroupPosition>([&](auto *pos) {
244244
getOperandTreePredicates(predList, val, builder, inputs, pos);
245245
})
246-
.Default([](auto *) { llvm_unreachable("unexpected position kind"); });
246+
.DefaultUnreachable("unexpected position kind");
247247
}
248248

249249
static void getAttributePredicates(pdl::AttributeOp op,

mlir/lib/Dialect/ArmSME/Transforms/OuterProductFusion.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class OuterProductFusion2Way
170170
op2, op.getResultType(), lhs, rhs, lhsMask, rhsMask,
171171
op1.getAcc());
172172
})
173-
.Default([&](auto) { llvm_unreachable("unexpected extend op!"); });
173+
.DefaultUnreachable("unexpected extend op!");
174174
} else if (kind == arm_sme::CombiningKind::Sub) {
175175
TypeSwitch<Operation *>(extOp)
176176
.Case<arith::ExtFOp>([&](auto) {
@@ -188,7 +188,7 @@ class OuterProductFusion2Way
188188
op2, op.getResultType(), lhs, rhs, lhsMask, rhsMask,
189189
op1.getAcc());
190190
})
191-
.Default([&](auto) { llvm_unreachable("unexpected extend op!"); });
191+
.DefaultUnreachable("unexpected extend op!");
192192
} else {
193193
llvm_unreachable("unexpected arm_sme::CombiningKind!");
194194
}

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ void GPUDialect::printType(Type type, DialectAsmPrinter &os) const {
375375
os << shape.back() << 'x' << fragTy.getElementType();
376376
os << ", \"" << fragTy.getOperand() << "\"" << '>';
377377
})
378-
.Default([](Type) { llvm_unreachable("unexpected 'gpu' type kind"); });
378+
.DefaultUnreachable("unexpected 'gpu' type kind");
379379
}
380380

381381
static LogicalResult verifyKnownLaunchSizeAttr(Operation *op,

mlir/lib/Dialect/Linalg/Transforms/Loops.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ static void replaceIndexOpsByInductionVariables(RewriterBase &rewriter,
192192
.Case([&](affine::AffineForOp affineForOp) {
193193
allIvs.push_back(affineForOp.getInductionVar());
194194
})
195-
.Default([&](Operation *op) { assert(false && "unexpected op"); });
195+
.DefaultUnreachable("unexpected op");
196196
}
197197
assert(linalgOp.getNumLoops() == allIvs.size() &&
198198
"expected the number of loops and induction variables to match");

mlir/lib/Dialect/MemRef/Transforms/FoldMemRefAliasOps.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ LogicalResult LoadOpOfSubViewOpFolder<OpTy>::matchAndRewrite(
315315
op, op.getType(), subViewOp.getSource(), sourceIndices,
316316
op.getTranspose(), op.getNumTiles());
317317
})
318-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
318+
.DefaultUnreachable("unexpected operation");
319319
return success();
320320
}
321321

@@ -367,7 +367,7 @@ LogicalResult LoadOpOfExpandShapeOpFolder<OpTy>::matchAndRewrite(
367367
op, op.getType(), expandShapeOp.getViewSource(), sourceIndices,
368368
op.getMask(), op.getPassThru());
369369
})
370-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
370+
.DefaultUnreachable("unexpected operation");
371371
return success();
372372
}
373373

@@ -415,7 +415,7 @@ LogicalResult LoadOpOfCollapseShapeOpFolder<OpTy>::matchAndRewrite(
415415
op, op.getType(), collapseShapeOp.getViewSource(), sourceIndices,
416416
op.getMask(), op.getPassThru());
417417
})
418-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
418+
.DefaultUnreachable("unexpected operation");
419419
return success();
420420
}
421421

@@ -482,7 +482,7 @@ LogicalResult StoreOpOfSubViewOpFolder<OpTy>::matchAndRewrite(
482482
op, op.getSrc(), subViewOp.getSource(), sourceIndices,
483483
op.getLeadDimension(), op.getTransposeAttr());
484484
})
485-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
485+
.DefaultUnreachable("unexpected operation");
486486
return success();
487487
}
488488

@@ -535,7 +535,7 @@ LogicalResult StoreOpOfExpandShapeOpFolder<OpTy>::matchAndRewrite(
535535
op, expandShapeOp.getViewSource(), sourceIndices, op.getMask(),
536536
op.getValueToStore());
537537
})
538-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
538+
.DefaultUnreachable("unexpected operation");
539539
return success();
540540
}
541541

@@ -584,7 +584,7 @@ LogicalResult StoreOpOfCollapseShapeOpFolder<OpTy>::matchAndRewrite(
584584
op, collapseShapeOp.getViewSource(), sourceIndices, op.getMask(),
585585
op.getValueToStore());
586586
})
587-
.Default([](Operation *) { llvm_unreachable("unexpected operation."); });
587+
.DefaultUnreachable("unexpected operation");
588588
return success();
589589
}
590590

mlir/lib/Tools/PDLL/AST/NodePrinter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ void NodePrinter::print(Type type) {
154154
})
155155
.Case([&](TypeType) { os << "Type"; })
156156
.Case([&](ValueType) { os << "Value"; })
157-
.Default([](Type) { llvm_unreachable("unknown AST type"); });
157+
.DefaultUnreachable("unknown AST type");
158158
}
159159

160160
void NodePrinter::print(const Node *node) {
@@ -182,7 +182,7 @@ void NodePrinter::print(const Node *node) {
182182
const VariableDecl,
183183

184184
const Module>([&](auto derivedNode) { this->printImpl(derivedNode); })
185-
.Default([](const Node *) { llvm_unreachable("unknown AST node"); });
185+
.DefaultUnreachable("unknown AST node");
186186
elementIndentStack.pop_back();
187187
}
188188

mlir/lib/Tools/PDLL/AST/Nodes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class NodeVisitor {
7272

7373
const Module>(
7474
[&](auto derivedNode) { this->visitImpl(derivedNode); })
75-
.Default([](const Node *) { llvm_unreachable("unknown AST node"); });
75+
.DefaultUnreachable("unknown AST node");
7676
}
7777

7878
private:

0 commit comments

Comments
 (0)