feat: improve version output

starpit · starpit · commit 1f35f525bda6 · 2019-10-22T09:58:07.000-04:00
Fixes #27
diff --git a/kui/kui.go b/kui/kui.go
@@ -18,6 +18,13 @@ import (
 	"strings"
 )
 
+// version information that will come from goreleaser
+var (
+	version = "dev"
+	commit  = "none"
+	date    = "unknown"
+)
+
 type KrewComponent interface {
 	init()
 }
@@ -158,7 +165,17 @@ func (component *KuiComponent) Run(context Context, args []string) {
 		}
 	}
 
+	if arg == "version" {
+		// also report our version
+		fmt.Printf("%v\t%v %v\n%v\t", blue(base), version, date, blue("kui"))
+	}
+
 	component.invokeRun(context, cmd, kaskArgs, style)
+
+	if arg == "version" {
+		// missing trailing newline; fixing here for now
+		fmt.Print("\n")
+	}
 }
 
 func (component *KuiComponent) invokeRun(context Context, cmd *exec.Cmd, kaskArgs []string, style ExecStyle) {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,13 @@ import (`
`18`	`18`	`"strings"`
`19`	`19`	`)`
`20`	`20`
	`21`	`+// version information that will come from goreleaser`
	`22`	`+var (`
	`23`	`+ version = "dev"`
	`24`	`+ commit = "none"`
	`25`	`+ date = "unknown"`
	`26`	`+)`
	`27`	`+`
`21`	`28`	`type KrewComponent interface {`
`22`	`29`	`init()`
`23`	`30`	`}`
`@@ -158,7 +165,17 @@ func (component *KuiComponent) Run(context Context, args []string) {`
`158`	`165`	`}`
`159`	`166`	`}`
`160`	`167`
	`168`	`+ if arg == "version" {`
	`169`	`+ // also report our version`
	`170`	`+ fmt.Printf("%v\t%v %v\n%v\t", blue(base), version, date, blue("kui"))`
	`171`	`+ }`
	`172`	`+`
`161`	`173`	`component.invokeRun(context, cmd, kaskArgs, style)`
	`174`	`+`
	`175`	`+ if arg == "version" {`
	`176`	`+ // missing trailing newline; fixing here for now`
	`177`	`+ fmt.Print("\n")`
	`178`	`+ }`
`162`	`179`	`}`
`163`	`180`
`164`	`181`	`func (component KuiComponent) invokeRun(context Context, cmd exec.Cmd, kaskArgs []string, style ExecStyle) {`