Skip to content

Commit cc8a4ad

Browse files
authored
refactor(rubocop): enable metrics cops after refactoring (#2539)
Enable previously disabled RuboCop cops now that code has been refactored: - Metrics/AbcSize (max 50) - Metrics/MethodLength (max 40) - Metrics/CyclomaticComplexity (max 10) - Naming/PredicateName (default) - Lint/MissingSuper (default) - Style/OpenStructUse (default) Remove TODO comments and exclusions that are no longer needed. Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
1 parent 1cf76fe commit cc8a4ad

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

.rubocop.yml

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,38 +13,20 @@ AllCops:
1313
Style/Documentation:
1414
Enabled: false
1515

16-
17-
# TODO: refactor large lambda blocks
1816
Metrics/BlockLength:
1917
Exclude:
2018
- '**/*_spec.rb'
21-
- 'jekyll-kuma-plugins/lib/jekyll/kuma_plugins/liquid/tags/policyyaml.rb'
2219

23-
# TODO: refactor generator methods
2420
Metrics/AbcSize:
25-
Enabled: false
21+
Max: 50
22+
Exclude:
23+
- 'spec/**/*'
2624

2725
Metrics/MethodLength:
28-
Enabled: false
26+
Max: 40
2927

3028
Metrics/CyclomaticComplexity:
31-
Enabled: false
32-
33-
# TODO: rename predicate methods
34-
Naming/PredicateName:
35-
Enabled: false
36-
37-
# TODO: call super in InstallPage#initialize
38-
Lint/MissingSuper:
39-
Enabled: false
40-
41-
# TODO: replace OpenStruct with Struct
42-
Style/OpenStructUse:
43-
Enabled: false
44-
45-
# Disable requirement for rubocop:enable after rubocop:disable
46-
Lint/MissingCopEnableDirective:
47-
Enabled: false
29+
Max: 10
4830

4931
Layout/LineLength:
5032
Max: 180

0 commit comments

Comments
 (0)