Merge pull request #9 from kumarvna/release/release-1.2.0-remove_provider_config

removing provider configuration dependency

Author: kumarvna

README.md

@@ -6,7 +6,10 @@ A single database is the quickest and simplest deployment option for Azure SQL D
 
 You can also create a single database in the provisioned or serverless compute tier. A provisioned database is pre-allocated a fixed amount of computing resources, including CPU and memory, and uses one of two purchasing models. This module creates a provisioned database using the vCore-based purchasing model, but you can choose a DTU-based model as well.
 
-## These types of resources are supported
+> **[NOTE]**
+> **This module now supports the meta arguments including `providers`, `depends_on`, `count`, and `for_each`.**
+
+## Resources supported
 
 * [SQL Servers](https://www.terraform.io/docs/providers/azurerm/r/sql_server.html)
 * [SQL Database](https://www.terraform.io/docs/providers/azurerm/r/mysql_database.html)
@@ -25,6 +28,11 @@ You can also create a single database in the provisioned or serverless compute t
 ## Module Usage
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"
@@ -183,55 +191,14 @@ Installation of the Microsoft `sqlcmd` utility on [Ubuntu](https://docs.microsof
 
 ## Recommended naming and tagging conventions
 
-Well-defined naming and metadata tagging conventions help to quickly locate and manage resources. These conventions also help associate cloud usage costs with business teams via chargeback and show back accounting mechanisms.
+Applying tags to your Azure resources, resource groups, and subscriptions to logically organize them into a taxonomy. Each tag consists of a name and a value pair. For example, you can apply the name `Environment` and the value `Production` to all the resources in production.
+For recommendations on how to implement a tagging strategy, see Resource naming and tagging decision guide.
 
-### Resource naming
+>**Important** :
+Tag names are case-insensitive for operations. A tag with a tag name, regardless of the casing, is updated or retrieved. However, the resource provider might keep the casing you provide for the tag name. You'll see that casing in cost reports. **Tag values are case-sensitive.**
 
 An effective naming convention assembles resource names by using important resource information as parts of a resource's name. For example, using these [recommended naming conventions](https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/naming-and-tagging#example-names), a public IP resource for a production SharePoint workload is named like this: `pip-sharepoint-prod-westus-001`.
 
-> ### Metadata tags
-
-When applying metadata tags to the cloud resources, you can include information about those assets that couldn't be included in the resource name. You can use that information to perform more sophisticated filtering and reporting on resources. This information can be used by IT or business teams to find resources or generate reports about resource usage and billing.
-
-The following list provides the recommended common tags that capture important context and information about resources. Use this list as a starting point to establish your tagging conventions.
-
-Tag Name|Description|Key|Example Value|Required?
---------|-----------|---|-------------|---------|
-Project Name|Name of the Project for the infra is created. This is mandatory to create a resource names.|ProjectName|{Project name}|Yes
-Application Name|Name of the application, service, or workload the resource is associated with.|ApplicationName|{app name}|Yes
-Approver|Name Person responsible for approving costs related to this resource.|Approver|{email}|Yes
-Business Unit|Top-level division of your company that owns the subscription or workload the resource belongs to. In smaller organizations, this may represent a single corporate or shared top-level organizational element.|BusinessUnit|FINANCE, MARKETING,{Product Name},CORP,SHARED|Yes
-Cost Center|Accounting cost center associated with this resource.|CostCenter|{number}|Yes
-Disaster Recovery|Business criticality of this application, workload, or service.|DR|Mission Critical, Critical, Essential|Yes
-Environment|Deployment environment of this application, workload, or service.|Env|Prod, Dev, QA, Stage, Test|Yes
-Owner Name|Owner of the application, workload, or service.|Owner|{email}|Yes
-Requester Name|User that requested the creation of this application.|Requestor| {email}|Yes
-Service Class|Service Level Agreement level of this application, workload, or service.|ServiceClass|Dev, Bronze, Silver, Gold|Yes
-Start Date of the project|Date when this application, workload, or service was first deployed.|StartDate|{date}|No
-End Date of the Project|Date when this application, workload, or service is planned to be retired.|EndDate|{date}|No
-
-> This module allows you to manage the above metadata tags directly or as an variable using `variables.tf`. All Azure resources which support tagging can be tagged by specifying key-values in argument `tags`. Tag `ResourceName` is added automatically to all resources.
-
-```hcl
-module "mssql-server" {
-  source  = "kumarvna/mssql-db/azurerm"
-  version = "1.1.0"
-
-  # Resource Group, location, VNet and Subnet details
-  resource_group_name  = "rg-hub-demo-internal-shared-westeurope-001"
-
-  # ... omitted
-
-  tags = {
-    ProjectName  = "demo-internal"
-    Env          = "dev"
-    Owner        = "[email protected]"
-    BusinessUnit = "CORP"
-    ServiceClass = "Gold"
-  }
-}
-```
-
 ## Requirements
 
 | Name | Version |

examples/README.md

@@ -7,6 +7,11 @@ Terraform module for Azure to create a MS SQL server with initial database, Azur
 ### Simple Azure SQL single database creation
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"
@@ -81,6 +86,11 @@ module "mssql-server" {
 ### Simple Azure SQL single database using private Endpoint
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"
@@ -160,6 +170,11 @@ module "mssql-server" {
 ### Azure SQL database creation using geo-replication with auto-failover groups
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"
@@ -238,6 +253,11 @@ module "mssql-server" {
 ### Azure SQL database creation using geo-replication with auto-failover groups and Private Endpoints
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"
@@ -332,25 +352,25 @@ Run `terraform destroy` when you don't need these resources.
 
 ## Outputs
 
-| Name                                         | Description                                                        |
-| -------------------------------------------- | ------------------------------------------------------------------ |
-| `resource_group_name`                        | The name of the resource group in which resources are created      |
-| `resource_group_location`                    | The location of the resource group in which resources are created  |
-| `storage_account_id`                         | The ID of the storage account                                      |
-| `storage_account_name`                       | The name of the storage account                                    |
-| `primary_sql_server_id`                      | The primary Microsoft SQL Server ID                                |
-| `primary_sql_server_fqdn`                    | The fully qualified domain name of the primary Azure SQL Server    |
-| `secondary_sql_server_id`                    | The secondary Microsoft SQL Server ID                              |
-| `secondary_sql_server_fqdn`                  | The fully qualified domain name of the secondary Azure SQL Server  |
-| `sql_server_admin_user`                      | SQL database administrator login id                                |
-| `sql_server_admin_password`                  | SQL database administrator login password                          |
-| `sql_database_id`                            | The SQL Database ID                                                |
-| `sql_database_name`                          | The SQL Database Name                                              |
-| `sql_failover_group_id`                      | A failover group of databases on a collection of Azure SQL servers |
-| `primary_sql_server_private_endpoint`        | id of the Primary SQL server Private Endpoint                      |
-| `secondary_sql_server_private_endpoint`      | id of the Primary SQL server Private Endpoint                      |
-| `sql_server_private_dns_zone_domain`         | DNS zone name of SQL server Private endpoints dns name records     |
-| `primary_sql_server_private_endpoint_ip`     | Primary SQL server private endpoint IPv4 Addresses                 |
-| `primary_sql_server_private_endpoint_fqdn`   | Primary SQL server private endpoint IPv4 Addresses                 |
-| `secondary_sql_server_private_endpoint_ip`   | Secondary SQL server private endpoint IPv4 Addresses               |
-| `secondary_sql_server_private_endpoint_fqdn` | Secondary SQL server private endpoint IPv4 Addresses               |
+Name | Description
+---- | -----------
+`resource_group_name` | The name of the resource group in which resources are created
+`resource_group_location`| The location of the resource group in which resources are created
+`storage_account_id`|The ID of the storage account
+`storage_account_name`|The name of the storage account
+`primary_sql_server_id`|The primary Microsoft SQL Server ID
+`primary_sql_server_fqdn`|The fully qualified domain name of the primary Azure SQL Server
+`secondary_sql_server_id`|The secondary Microsoft SQL Server ID
+`secondary_sql_server_fqdn`|The fully qualified domain name of the secondary Azure SQL Server
+`sql_server_admin_user`|SQL database administrator login id
+`sql_server_admin_password`|SQL database administrator login password
+`sql_database_id`|The SQL Database ID
+`sql_database_name`|The SQL Database Name
+`sql_failover_group_id`|A failover group of databases on a collection of Azure SQL servers
+`primary_sql_server_private_endpoint`|id of the Primary SQL server Private Endpoint
+`secondary_sql_server_private_endpoint`|id of the Primary SQL server Private Endpoint
+`sql_server_private_dns_zone_domain`|DNS zone name of SQL server Private endpoints DNS name records
+`primary_sql_server_private_endpoint_ip`|Primary SQL server private endpoint IPv4 Addresses
+`primary_sql_server_private_endpoint_fqdn`|Primary SQL server private endpoint IPv4 Addresses
+`secondary_sql_server_private_endpoint_ip`|Secondary SQL server private endpoint IPv4 Addresses
+`secondary_sql_server_private_endpoint_fqdn`|Secondary SQL server private endpoint FQDN Addresses

examples/SQL_DB_Using_Geo-replication_with_Auto-Failover_Groups/README.md

@@ -5,6 +5,11 @@ Terraform module to create a SQL server with initial database, Azure AD login, F
 ## Module Usage
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/SQL_DB_Using_Geo-replication_with_Auto-Failover_Groups/main.tf

@@ -1,3 +1,8 @@
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/SQL_DB_Using_Geo-replication_with_Auto-Failover_Groups_and_Private_Endpoints/README.md

@@ -5,6 +5,11 @@ Terraform module to create a SQL server with initial database, Azure AD login, F
 ## Module Usage
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/SQL_DB_Using_Geo-replication_with_Auto-Failover_Groups_and_Private_Endpoints/main.tf

@@ -1,3 +1,8 @@
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/Simple_SQL_Single_Database_Using_Private_Endpoint/README.md

@@ -5,6 +5,11 @@ Terraform module to create a SQL server with initial database, Azure AD login, F
 ## Module Usage
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/Simple_SQL_Single_Database_Using_Private_Endpoint/main.tf

@@ -1,3 +1,8 @@
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/Simple_SQL_Single_Database_creation/README.md

@@ -5,6 +5,11 @@ Terraform module to create a SQL server with initial database, Azure AD login, F
 ## Module Usage
 
 ```hcl
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"

examples/Simple_SQL_Single_Database_creation/main.tf

@@ -1,3 +1,8 @@
+# Azurerm provider configuration
+provider "azurerm" {
+  features {}
+}
+
 module "mssql-server" {
   source  = "kumarvna/mssql-db/azurerm"
   version = "1.1.0"