Skip to content

Commit 2838997

Browse files
committed
documentation for version 1.0
1 parent 1a735b2 commit 2838997

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Azure Cache for Redis provides an in-memory data store based on the Redis softwa
1010
* [Redis Cache Cluser](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/redis_cache#shard_count)
1111
* [Redis Cache Virtual Network Support](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/redis_cache#subnet_id)
1212
* [Redis Cache Data Persistence](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/redis_cache#rdb_backup_enabled)
13-
* [Redis Diagnostics](https://docs.microsoft.com/en-us/azure/azure-sql/database/metrics-diagnostic-telemetry-logging-streaming-export-configure?tabs=azure-portal)
13+
* [Redis Monitoring Diagnostics](https://docs.microsoft.com/en-us/azure/azure-sql/database/metrics-diagnostic-telemetry-logging-streaming-export-configure?tabs=azure-portal)
1414
* [Private Endpoints](https://www.terraform.io/docs/providers/azurerm/r/private_endpoint.html)
1515
* [Private DNS zone for `privatelink` A records](https://www.terraform.io/docs/providers/azurerm/r/private_dns_zone.html)
1616

@@ -127,15 +127,15 @@ By default, this feature not enabled on this module. To create private link with
127127

128128
For more details: [Private Link for Azure Database for MySQL](https://docs.microsoft.com/en-us/azure/mysql/concepts-data-access-security-private-link)
129129

130-
> [!IMPORTANT]
130+
> **[IMPORTANT]**
131131
> There is a `publicNetworkAccess` flag which is `Disabled` by default. This flag is meant to allow you to optionally allow both public and private endpoint access to the cache if it is set to `Enabled`. If set to `Disabled`, it will only allow private endpoint access. You can set the value to `Disabled` or `Enabled`.
132132
>
133133
## Recommended naming and tagging conventions
134134

135135
Applying tags to your Azure resources, resource groups, and subscriptions to logically organize them into a taxonomy. Each tag consists of a name and a value pair. For example, you can apply the name `Environment` and the value `Production` to all the resources in production.
136136
For recommendations on how to implement a tagging strategy, see Resource naming and tagging decision guide.
137137

138-
> [!IMPORTANT]
138+
> [IMPORTANT]
139139
> Tag names are case-insensitive for operations. A tag with a tag name, regardless of the casing, is updated or retrieved. However, the resource provider might keep the casing you provide for the tag name. You'll see that casing in cost reports. **Tag values are case-sensitive.**
140140
>
141141

main.tf

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -93,23 +93,12 @@ resource "azurerm_redis_cache" "main" {
9393
rdb_backup_max_snapshot_count = each.value["sku_name"] == "Premium" && var.enable_data_persistence == true ? var.data_persistence_backup_max_snapshot_count : null
9494
rdb_storage_connection_string = each.value["sku_name"] == "Premium" && var.enable_data_persistence == true ? azurerm_storage_account.storeacc.0.primary_blob_connection_string : null
9595
}
96-
/*
97-
patch_schedule {
98-
day_of_week = each.value.patch_schedule["days_of_week"]
99-
start_hour_utc = each.value.patch_schedule["start_hour_utc"]
100-
}
101-
102-
patch_schedule {
103-
day_of_week = lookup(var.patch_schedule, "day_of_week")
104-
start_hour_utc = lookup(var.patch_schedule, "start_hour_utc")
105-
}
106-
*/
10796

10897
dynamic "patch_schedule" {
10998
for_each = var.patch_schedule != null ? [var.patch_schedule] : []
11099
content {
111-
day_of_week = var.patch_schedule.day_of_week #lookup(var.patch_schedule, "day_of_week", null)
112-
start_hour_utc = var.patch_schedule.start_hour_utc #lookup(var.patch_schedule, "start_hour_utc", null)
100+
day_of_week = var.patch_schedule.day_of_week
101+
start_hour_utc = var.patch_schedule.start_hour_utc
113102
}
114103
}
115104

@@ -133,7 +122,7 @@ resource "azurerm_redis_firewall_rule" "name" {
133122

134123

135124
#---------------------------------------------------------
136-
# Private Link for SQL Server - Default is "false"
125+
# Private Link for Redis Server - Default is "false"
137126
#---------------------------------------------------------
138127
data "azurerm_virtual_network" "vnet01" {
139128
count = var.enable_private_endpoint ? 1 : 0

0 commit comments

Comments
 (0)