updating module to support more features

Author: kumarvna

main.tf

@@ -67,8 +67,7 @@ resource "azurerm_public_ip" "pip" {
   sku                 = var.public_ip_sku
   sku_tier            = var.public_ip_sku_tier
   domain_name_label   = var.domain_name_label
-  # availability_zone   = var.public_ip_availability_zone
-  tags = merge({ "resourcename" = lower("pip-vm-${var.vmscaleset_name}-${data.azurerm_resource_group.rg.location}-0${count.index + 1}") }, var.tags, )
+  tags                = merge({ "resourcename" = lower("pip-vm-${var.vmscaleset_name}-${data.azurerm_resource_group.rg.location}-0${count.index + 1}") }, var.tags, )
 
   lifecycle {
     ignore_changes = [
@@ -91,8 +90,8 @@ resource "azurerm_lb" "vmsslb" {
   frontend_ip_configuration {
     name                          = var.load_balancer_type == "public" ? lower("lbext-frontend-${var.vmscaleset_name}") : lower("lbint-frontend-${var.vmscaleset_name}")
     public_ip_address_id          = var.enable_load_balancer == true && var.load_balancer_type == "public" ? azurerm_public_ip.pip[count.index].id : null
-    private_ip_address_allocation = var.load_balancer_type == "private" ? var.private_ip_address_allocation : null
-    private_ip_address            = var.load_balancer_type == "private" && var.private_ip_address_allocation == "Static" ? var.lb_private_ip_address : null
+    private_ip_address_allocation = var.load_balancer_type == "private" ? var.private_ip_address_allocation_type : null
+    private_ip_address            = var.load_balancer_type == "private" && var.private_ip_address_allocation_type == "Static" ? var.lb_private_ip_address : null
     subnet_id                     = var.load_balancer_type == "private" ? data.azurerm_subnet.snet.id : null
   }
 

variables.tf

@@ -13,11 +13,6 @@ variable "subnet_name" {
   default     = ""
 }
 
-variable "log_analytics_workspace_name" {
-  description = "The name of log analytics workspace name"
-  default     = null
-}
-
 variable "storage_account_name" {
   description = "The name of the hub storage account to store logs"
   default     = null
@@ -43,11 +38,6 @@ variable "domain_name_label" {
   default     = null
 }
 
-variable "public_ip_availability_zone" {
-  description = "The availability zone to allocate the Public IP in. Possible values are `Zone-Redundant`, `1`,`2`, `3`, and `No-Zone`"
-  default     = "Zone-Redundant"
-}
-
 variable "public_ip_sku_tier" {
   description = "The SKU Tier that should be used for the Public IP. Possible values are `Regional` and `Global`"
   default     = "Regional"
@@ -67,7 +57,7 @@ variable "load_balancer_sku" {
   description = "The SKU of the Azure Load Balancer. Accepted values are Basic and Standard."
   default     = "Standard"
 }
-variable "private_ip_address_allocation" {
+variable "private_ip_address_allocation_type" {
   description = "The allocation method for the Private IP Address used by this Load Balancer. Possible values as Dynamic and Static."
   default     = "Dynamic"
 }
@@ -88,7 +78,7 @@ variable "lb_probe_request_path" {
 }
 
 variable "number_of_probes" {
-  description = " The number of failed probe attempts after which the backend endpoint is removed from rotation. The default value is `2`. `NumberOfProbes` multiplied by `intervalInSeconds` value must be greater or equal to 10.Endpoints are returned to rotation when at least one probe is successful."
+  description = "The number of failed probe attempts after which the backend endpoint is removed from rotation. The default value is `2`. `NumberOfProbes` multiplied by `intervalInSeconds` value must be greater or equal to 10.Endpoints are returned to rotation when at least one probe is successful."
   default     = null
 }
 
@@ -151,7 +141,7 @@ variable "virtual_machine_size" {
 
 variable "instances_count" {
   description = "The number of Virtual Machines in the Scale Set."
-  default     = 1
+  default     = 2
 }
 
 variable "admin_username" {