update module

Author: kumarvit

main.tf

@@ -70,7 +70,7 @@ resource "azurerm_public_ip" "pip" {
   resource_group_name = data.azurerm_resource_group.rg.name
   allocation_method   = "Static"
   sku                 = "Standard"
-  domain_name_label   = format("vm-%s-pip-0${count.index + 1}", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")))
+  domain_name_label   = format("vm%spip0${count.index + 1}", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")))
   tags                = merge({ "ResourceName" = lower("pip-vm-${var.vmscaleset_name}-${data.azurerm_resource_group.rg.location}-0${count.index + 1}") }, var.tags, )
 }
 
@@ -277,8 +277,8 @@ resource "azurerm_linux_virtual_machine_scale_set" "linux_vmss" {
 #---------------------------------------
 resource "azurerm_windows_virtual_machine_scale_set" "winsrv_vmss" {
   count                  = var.os_flavor == "windows" ? 1 : 0
-  name                   = format("vm%s%s", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")), count.index + 1)
-  computer_name_prefix   = format("%s-vmss", "win") # not more than 9 characters
+  name                   = format("%s", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")))
+  computer_name_prefix   = format("%s%s", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")), count.index + 1)
   resource_group_name    = data.azurerm_resource_group.rg.name
   location               = data.azurerm_resource_group.rg.location
   overprovision          = var.overprovision
@@ -289,7 +289,7 @@ resource "azurerm_windows_virtual_machine_scale_set" "winsrv_vmss" {
   single_placement_group = var.single_placement_group
   admin_username         = var.admin_username
   admin_password         = var.admin_password == null ? random_password.passwd[count.index].result : var.admin_password
-  tags                   = merge({ "ResourceName" = format("vm%s%s", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", "")), count.index + 1) }, var.tags, )
+  tags                   = merge({ "ResourceName" = format("%s", lower(replace(var.vmscaleset_name, "/[[:^alnum:]]/", ""))) }, var.tags, )
   source_image_id        = var.source_image_id != null ? var.source_image_id : null
   upgrade_mode           = var.os_upgrade_mode
   health_probe_id        = var.enable_load_balancer ? azurerm_lb_probe.lbp[0].id : null