Skip to content

Commit 73d241a

Browse files
committed
Merge branch '4.1'
* 4.1: review doc chapter for belittling words review getting started chapter for belittling words review best practice chapter for belittling words
2 parents 9be63a9 + 0b5d88c commit 73d241a

File tree

110 files changed

+249
-249
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+249
-249
lines changed

best_practices/business-logic.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Both formats have the same performance, so this is ultimately a matter of
110110
personal taste.
111111

112112
We recommend YAML because it's friendly to newcomers and concise. You can
113-
of course use whatever format you like.
113+
use any of the other formats if you prefer another format.
114114

115115
Using a Persistence Layer
116116
-------------------------

best_practices/controllers.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ When Things Get More Advanced
181181

182182
The above example works without any configuration because the wildcard name
183183
``{id}`` matches the name of the property on the entity. If this isn't true, or
184-
if you have even more complex logic, the easiest thing to do is just query for
184+
if you have even more complex logic, your best choice is to query for
185185
the entity manually. In our application, we have this situation in
186186
``CommentController``::
187187

best_practices/introduction.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ It's also a moving target that will continue to improve.
4949

5050
Keep in mind that these are **optional recommendations** that you and your
5151
team may or may not follow to develop Symfony applications. If you want to
52-
continue using your own best practices and methodologies, you can of course
53-
do it. Symfony is flexible enough to adapt to your needs. That will never
52+
continue using your own best practices and methodologies, you can still do
53+
that. Symfony is flexible enough to adapt to your needs. That will never
5454
change.
5555

5656
Who this Book Is for (Hint: It's not a Tutorial)

best_practices/templates.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Twig Extensions
5858

5959
Our application needs a custom ``md2html`` Twig filter so that we can transform
6060
the Markdown contents of each post into HTML. To do this, create a new
61-
``Markdown`` class that will be used later by the Twig extension. It just needs
61+
``Markdown`` class that will be used later by the Twig extension. It needs
6262
to define one single method to transform Markdown content into HTML::
6363

6464
namespace App\Utils;

best_practices/tests.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ functional tests, you can quickly spot any big errors before you deploy them:
2727
Define a functional test that at least checks if your application pages
2828
are successfully loading.
2929

30-
A functional test like this is simple to implement thanks to
31-
:ref:`PHPUnit data providers <testing-data-providers>`::
30+
:ref:`PHPUnit data providers <testing-data-providers>` help you implement
31+
functional tests::
3232

3333
// tests/ApplicationAvailabilityFunctionalTest.php
3434
namespace App\Tests;

bundles/best_practices.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ vendor segment, followed by zero or more category segments, and it ends with the
2323
namespace short name, which must end with ``Bundle``.
2424

2525
A namespace becomes a bundle as soon as you add a bundle class to it. The
26-
bundle class name must follow these simple rules:
26+
bundle class name must follow these rules:
2727

2828
* Use only alphanumeric characters and underscores;
2929
* Use a StudlyCaps name (i.e. camelCase with the first letter uppercased);
@@ -467,8 +467,9 @@ Retrieve the configuration parameters in your code from the container::
467467

468468
$container->getParameter('acme_blog.author.email');
469469

470-
Even if this mechanism is simple enough, you should consider using the more
471-
advanced :doc:`semantic bundle configuration </bundles/configuration>`.
470+
While this mechanism requires the least effort, you should consider using the
471+
more advanced :doc:`semantic bundle configuration </bundles/configuration>` to
472+
make your configuration more robust.
472473

473474
Versioning
474475
----------

bundles/override.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ the routes from any bundle, then they must be manually imported from somewhere
6868
in your application (e.g. ``config/routes.yaml``).
6969

7070
The easiest way to "override" a bundle's routing is to never import it at
71-
all. Instead of importing a third-party bundle's routing, simply copy
71+
all. Instead of importing a third-party bundle's routing, copy
7272
that routing file into your application, modify it, and import it instead.
7373

7474
Controllers

configuration/configuration_organization.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ How to Organize Configuration Files
55
===================================
66

77
The Symfony skeleton defines three :doc:`execution environments </configuration/environments>`
8-
called ``dev``, ``prod`` and ``test``. An environment simply represents a way
8+
called ``dev``, ``prod`` and ``test``. An environment represents a way
99
to execute the same codebase with different configurations.
1010

1111
In order to select the configuration file to load for each environment, Symfony
@@ -129,9 +129,9 @@ Global Configuration Files
129129

130130
Some system administrators may prefer to store sensitive parameters in files
131131
outside the project directory. Imagine that the database credentials for your
132-
website are stored in the ``/etc/sites/mysite.com/parameters.yaml`` file. Loading
133-
this file is as simple as indicating the full file path when importing it from
134-
any other configuration file:
132+
website are stored in the ``/etc/sites/mysite.com/parameters.yaml`` file. You
133+
can load files from outside the project folder by indicating the full file path
134+
when importing it from any other configuration file:
135135

136136
.. configuration-block::
137137

configuration/environments.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ Creating a new Environment
203203
--------------------------
204204

205205
Since an environment is nothing more than a string that corresponds to a set of
206-
configuration, creating a new environment is quite easy.
206+
configuration, you can also create your own environments for specific purposes.
207207

208208
Suppose, for example, that before deployment, you need to benchmark your
209209
application. One way to benchmark the application is to use near-production
@@ -359,7 +359,7 @@ includes the following:
359359

360360
.. note::
361361

362-
You can easily change the directory location and name. For more information
362+
You can change the directory location and name. For more information
363363
read the article :doc:`/configuration/override_dir_structure`.
364364

365365
Going further

configuration/front_controllers_and_kernel.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ You can choose the front controller that's used by adding it in the URL, like:
5151
http://localhost/index.php/some/path/...
5252
5353
As you can see, this URL contains the PHP script to be used as the front
54-
controller. You can use that to easily switch to a custom made front controller
54+
controller. You can use that to switch to a custom made front controller
5555
that is located in the ``public/`` directory.
5656

5757
.. seealso::
@@ -123,7 +123,7 @@ controller to make use of the new kernel.
123123
The Environments
124124
----------------
125125

126-
As just mentioned, the ``Kernel`` has to implement another method -
126+
As mentioned above, the ``Kernel`` has to implement another method -
127127
:method:`Symfony\\Bundle\\FrameworkBundle\\Kernel\\MicroKernelTrait::configureContainer`.
128128
This method is responsible for loading the application's configuration from the
129129
right *environment*.

0 commit comments

Comments
 (0)