Skip to content

Commit 08aaee8

Browse files
committed
More fixes
1 parent 9da7386 commit 08aaee8

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

cmake/platforms/yup_android.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function (_yup_android_prepare_gradle)
5454
file (RELATIVE_PATH YUP_ANDROID_APPLICATION_PATH "${CMAKE_CURRENT_BINARY_DIR}/app" "${YUP_ANDROID_APPLICATION_PATH}")
5555

5656
# Prepare files
57-
set (BASE_FILES_PATH "${CMAKE_SOURCE_DIR}/cmake/platforms/android")
57+
set (BASE_FILES_PATH "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/android")
5858
configure_file (${BASE_FILES_PATH}/build.gradle.kts.in ${CMAKE_CURRENT_BINARY_DIR}/build.gradle.kts)
5959
configure_file (${BASE_FILES_PATH}/settings.gradle.kts.in ${CMAKE_CURRENT_BINARY_DIR}/settings.gradle.kts)
6060
configure_file (${BASE_FILES_PATH}/app/build.gradle.kts.in ${CMAKE_CURRENT_BINARY_DIR}/app/build.gradle.kts)

cmake/yup.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ function (_yup_setup_platform)
7474
_yup_message (STATUS "Setting up for ${platform} platform")
7575
_yup_message (STATUS "Running on cmake ${CMAKE_VERSION}")
7676

77-
set (YUP_PLATFORM "${platform}" PARENT_SCOPE)
77+
set (YUP_PLATFORM "${platform}" CACHE STRING INTERNAL)
7878

7979
foreach (platform_name ${platforms})
8080
string (TOUPPER "${platform_name}" platform_name_upper)
81-
set (YUP_PLATFORM_${platform_name_upper} ON PARENT_SCOPE)
81+
set (YUP_PLATFORM_${platform_name_upper} ON CACHE BOOL INTERNAL)
8282
endforeach()
8383

8484
endfunction()

cmake/yup_standalone.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function (yup_standalone_app)
3636
cmake_parse_arguments (YUP_ARG "${options}" "${one_value_args}" "${multi_value_args}" ${ARGN})
3737

3838
_yup_set_default (YUP_ARG_TARGET_CXX_STANDARD 20)
39-
_yup_set_default (YUP_ARG_TARGET_ICON "${CMAKE_SOURCE_DIR}/cmake/resources/app-icon.png")
39+
_yup_set_default (YUP_ARG_TARGET_ICON "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/resources/app-icon.png")
4040

4141
set (target_name "${YUP_ARG_TARGET_NAME}")
4242
set (target_version "${YUP_ARG_TARGET_VERSION}")
@@ -125,7 +125,7 @@ function (yup_standalone_app)
125125
# ==== Per platform configuration
126126
if (YUP_PLATFORM_APPLE)
127127
if (NOT "${target_console}" AND NOT "${target_wheel}")
128-
_yup_set_default (YUP_ARG_CUSTOM_PLIST "${CMAKE_SOURCE_DIR}/cmake/platforms/${YUP_PLATFORM}/Info.plist")
128+
_yup_set_default (YUP_ARG_CUSTOM_PLIST "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/platforms/${YUP_PLATFORM}/Info.plist")
129129
_yup_valid_identifier_string ("${target_app_identifier}" target_app_identifier)
130130

131131
_yup_message (STATUS "${target_name} - Converting application input icon to apple .icns format")
@@ -164,7 +164,7 @@ function (yup_standalone_app)
164164
set_target_properties (${target_name} PROPERTIES SUFFIX ".html")
165165
endif()
166166

167-
_yup_set_default (YUP_ARG_CUSTOM_SHELL "${CMAKE_SOURCE_DIR}/cmake/platforms/${YUP_PLATFORM}/shell.html")
167+
_yup_set_default (YUP_ARG_CUSTOM_SHELL "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/platforms/${YUP_PLATFORM}/shell.html")
168168
_yup_set_default (YUP_ARG_INITIAL_MEMORY 33554432) # 32mb
169169
_yup_set_default (YUP_ARG_PTHREAD_POOL_SIZE 8)
170170

@@ -209,7 +209,7 @@ function (yup_standalone_app)
209209
add_custom_command(
210210
TARGET ${target_name} POST_BUILD
211211
COMMAND ${CMAKE_COMMAND} -E copy
212-
"${CMAKE_SOURCE_DIR}/cmake/platforms/${YUP_PLATFORM}/mini-coi.js"
212+
"${CMAKE_CURRENT_FUNCTION_LIST_DIR}/platforms/${YUP_PLATFORM}/mini-coi.js"
213213
"${target_copy_dest}/mini-coi.js")
214214

215215
elseif (YUP_PLATFORM_LINUX)

cmake/yup_utilities.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ function (_yup_execute_process_or_fail)
277277
OUTPUT_QUIET)
278278

279279
if (NOT result EQUAL 0)
280-
_yup_join_list_with_separator ("${command}" " " "" "" command_string)
280+
_yup_join_list_with_separator ("${ARGN}" " " "" "" command_string)
281281
message (FATAL_ERROR "Failed to execute command '${command_string}': ${error_message}")
282282
endif()
283283
endfunction()

0 commit comments

Comments
 (0)