Improved

kunitoki · kunitoki · commit 1ec998ac6887 · 2025-08-04T18:21:42.000+02:00
diff --git a/modules/yup_dsp/filters/yup_ButterworthFilter.h b/modules/yup_dsp/filters/yup_ButterworthFilter.h
@@ -225,6 +225,11 @@ class ButterworthFilter : public BiquadCascade<SampleType, CoeffType>
     void getPolesZeros (ComplexVector<CoeffType>& poles,
                         ComplexVector<CoeffType>& zeros) const override
     {
+        poles.clear();
+        zeros.clear();
+        
+        for (const auto& coeffs : coefficients)
+            extractPolesZerosFromSecondOrderBiquad (coeffs.b0, coeffs.b1, coeffs.b2, coeffs.a0, coeffs.a1, coeffs.a2, poles, zeros);
     }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,11 @@ class ButterworthFilter : public BiquadCascade<SampleType, CoeffType>`
`225`	`225`	`void getPolesZeros (ComplexVector<CoeffType>& poles,`
`226`	`226`	`ComplexVector<CoeffType>& zeros) const override`
`227`	`227`	`{`
	`228`	`+ poles.clear();`
	`229`	`+ zeros.clear();`
	`230`	`+`
	`231`	`+ for (const auto& coeffs : coefficients)`
	`232`	`+ extractPolesZerosFromSecondOrderBiquad (coeffs.b0, coeffs.b1, coeffs.b2, coeffs.a0, coeffs.a1, coeffs.a2, poles, zeros);`
`228`	`233`	`}`
`229`	`234`
`230`	`235`	`private:`