Avoid opening documents when no DISPLAY is present

kunitoki · kunitoki · commit 6486a68fafdb · 2025-12-11T23:35:27.000+01:00
diff --git a/modules/yup_core/native/yup_Files_linux.cpp b/modules/yup_core/native/yup_Files_linux.cpp
@@ -272,6 +272,11 @@ static bool isFileExecutable (const String& filename)
 
 static bool openDocumentExternally (const String& fileName, const String& parameters, const Array<char*>* environment = nullptr)
 {
+    const bool hasDisplay = std::getenv ("DISPLAY") != nullptr && std::strlen (std::getenv ("DISPLAY")) > 0;
+
+    if (! hasDisplay)
+        return false;
+
     const auto cmdString = [&]
     {
         if (fileName.startsWithIgnoreCase ("file:")

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,11 @@ static bool isFileExecutable (const String& filename)`
`272`	`272`
`273`	`273`	`static bool openDocumentExternally (const String& fileName, const String& parameters, const Array<char> environment = nullptr)`
`274`	`274`	`{`
	`275`	`+ const bool hasDisplay = std::getenv ("DISPLAY") != nullptr && std::strlen (std::getenv ("DISPLAY")) > 0;`
	`276`	`+`
	`277`	`+ if (! hasDisplay)`
	`278`	`+ return false;`
	`279`	`+`
`275`	`280`	`const auto cmdString = [&]`
`276`	`281`	`{`
`277`	`282`	`if (fileName.startsWithIgnoreCase ("file:")`