Improved repainting

Author: kunitoki

modules/yup_gui/component/yup_Component.cpp

@@ -108,7 +108,7 @@ void Component::setVisible (bool shouldBeVisible)
     if (bailOutChecker.shouldBailOut())
         return;
 
-    repaint();
+    internalRepaint();
 }
 
 bool Component::isShowing() const
@@ -515,11 +515,10 @@ void Component::repaint (const Rectangle<float>& rect)
 {
     jassert (! options.isRepainting); // You are likely repainting from paint !
 
-    if (rect.isEmpty() || ! isShowing())
+    if (rect.isEmpty() || ! isShowing())
         return;
 
-    if (auto nativeComponent = getNativeComponent())
-        nativeComponent->repaint (rect.translated (getBoundsRelativeToTopLevelComponent().getTopLeft()));
+    internalRepaint (rect);
 }
 
 //==============================================================================
@@ -756,6 +755,10 @@ void Component::removeChildComponent (int index)
         return;
 
     auto component = children.removeAndReturn (index);
+
+    if (component->isShowing())
+        repaint (component->getBounds());
+
     component->parentComponent = nullptr;
 
     auto bailOutChecker = BailOutChecker (this);
@@ -1085,7 +1088,7 @@ bool Component::hasOpaqueChildCoveringArea (const Rectangle<float>& area)
     for (int childIndex = children.size(); --childIndex >= 0;)
     {
         auto child = children.getUnchecked (childIndex);
-        if (! child->isVisible() || ! child->isOpaque() || child->options.unclippedRendering || child->isTransformed())
+        if (! child->isVisible() || ! child->isOpaque() || child->options.unclippedRendering || child->isTransformed())
             continue;
 
         auto childBounds = child->getBoundsRelativeToTopLevelComponent();
@@ -1108,6 +1111,22 @@ void Component::internalRefreshDisplay (double lastFrameTimeSeconds)
 
 //==============================================================================
 
+void Component::internalRepaint()
+{
+    internalRepaint (getLocalBounds());
+}
+
+void Component::internalRepaint (const Rectangle<float>& rect)
+{
+    if (rect.isEmpty())
+        return;
+
+    if (auto nativeComponent = getNativeComponent())
+        nativeComponent->repaint (rect.translated (getBoundsRelativeToTopLevelComponent().getTopLeft()));
+}
+
+//==============================================================================
+
 void Component::internalPaint (Graphics& g, const Rectangle<float>& repaintArea, bool renderContinuous)
 {
     if (! isVisible() || (getWidth() == 0 || getHeight() == 0))

modules/yup_gui/component/yup_Component.h

@@ -1179,6 +1179,8 @@ class YUP_API Component
 
 private:
     void internalRefreshDisplay (double lastFrameTimeSeconds);
+    void internalRepaint();
+    void internalRepaint (const Rectangle<float>& rect);
     void internalPaint (Graphics& g, const Rectangle<float>& repaintArea, bool renderContinuous);
     void internalMouseEnter (const MouseEvent& event);
     void internalMouseExit (const MouseEvent& event);

modules/yup_gui/menus/yup_PopupMenu.cpp

@@ -366,6 +366,7 @@ PopupMenu::Options& PopupMenu::Options::withMaximumWidth (int maxWidth)
 PopupMenu::PopupMenu (const Options& options)
     : options (options)
 {
+    setOpaque (false);
 }
 
 PopupMenu::~PopupMenu()