More test coverage

Author: kunitoki

modules/yup_core/system/yup_SystemStats.cpp

@@ -214,7 +214,7 @@ uint64 SystemStats::getCompileUniqueId()
 }
 
 //==============================================================================
-#if YUP_ANDROID
+#if YUP_ANDROID && __ANDROID_API__ < 33
 struct BacktraceState
 {
     BacktraceState (void** current, void** end)
@@ -295,26 +295,11 @@ String SystemStats::getStackBacktrace()
     _Unwind_Backtrace (unwindCallback, &state);
 
     auto frames = static_cast<size_t> (state.current - &stack[0]);
-    for (auto i = (decltype (frames)) 0; i < frames; ++i)
-    {
-        Dl_info info;
-        if (dladdr (stack[i], &info))
-        {
-            int status = 0;
-            std::unique_ptr<char, decltype (::free)*> demangled (abi::__cxa_demangle (info.dli_sname, nullptr, 0, &status), ::free);
-
-            result
-                << yup::String (i).paddedRight (' ', 3)
-                << " " << yup::File (yup::String (info.dli_fname)).getFileName().paddedRight (' ', 35)
-                << " 0x" << yup::String::toHexString ((size_t) stack[i]).paddedLeft ('0', sizeof (void*) * 2)
-                << " " << demangled.get()
-                << " + " << ((char*) stack[i] - (char*) info.dli_saddr) << newLine;
-        }
-    }
-
+    char** frameStrings = nullptr;
 #else
     auto frames = backtrace (stack, numElementsInArray (stack));
     char** frameStrings = backtrace_symbols (stack, frames);
+#endif
 
     for (auto i = (decltype (frames)) 0; i < frames; ++i)
     {
@@ -336,9 +321,9 @@ String SystemStats::getStackBacktrace()
             }
         }
 
-        result << frameStrings[i] << newLine;
+        if (frameStrings != nullptr)
+            result << frameStrings[i] << newLine;
     }
-#endif
 #endif
 
     return result;

modules/yup_core/text/yup_String.cpp

@@ -2031,26 +2031,18 @@ bool String::containsNonWhitespaceChars() const noexcept
 
 String String::reversed() const
 {
-    if (isEmpty())
-        return *this;
-
-    // Count characters first to know how much space we need
-    int numChars = length();
+    const int numChars = length();
     if (numChars <= 0)
-        return {};
+        return *this;
 
-    // Create array to store character positions
     HeapBlock<CharPointerType> positions (numChars);
 
-    // Build the result by iterating backwards through characters
     StringCreationHelper builder (text);
 
-    // Store the start position of each character
     int index = 0;
     for (auto it = text; ! it.isEmpty() && index < numChars; ++it, ++index)
         positions[index] = it;
 
-    // Now write characters in reverse order
     for (int i = index - 1; i >= 0; --i)
         builder.write (*positions[i]);
 

modules/yup_core/xml/yup_XmlElement.cpp

@@ -467,7 +467,9 @@ bool XmlElement::hasTagName (StringRef possibleTagName) const noexcept
 
 String XmlElement::getNamespace() const
 {
-    return tagName.upToFirstOccurrenceOf (":", false, false);
+    return tagName.contains(":")
+        ? tagName.upToFirstOccurrenceOf (":", false, false)
+        : String();
 }
 
 String XmlElement::getTagNameWithoutNamespace() const

modules/yup_python/utilities/yup_CrashHandling.cpp

@@ -21,94 +21,14 @@
 
 #include "yup_CrashHandling.h"
 
-#if defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) || defined(__GLIBCPP__)
-#include <cxxabi.h>
-#include <execinfo.h>
-#include <dlfcn.h>
-#else
-#include "yup_WindowsIncludes.h"
-#endif
-
 namespace yup::Helpers
 {
 
 //==============================================================================
 
-String getStackBacktrace()
-{
-    String result;
-
-#if YUP_WINDOWS
-    HANDLE process = GetCurrentProcess();
-    SymInitialize (process, nullptr, TRUE);
-
-    void* stack[128];
-    int frames = static_cast<int> (CaptureStackBackTrace (0, numElementsInArray (stack), stack, nullptr));
-
-    HeapBlock<SYMBOL_INFO> symbol;
-    symbol.calloc (sizeof (SYMBOL_INFO) + 256, 1);
-    symbol->MaxNameLen = 255;
-    symbol->SizeOfStruct = sizeof (SYMBOL_INFO);
-
-    for (int i = 0; i < frames; ++i)
-    {
-        DWORD64 displacement = 0;
-
-        if (SymFromAddr (process, reinterpret_cast<DWORD64> (stack[i]), &displacement, symbol))
-        {
-            result << i << ": ";
-
-            IMAGEHLP_MODULE64 moduleInfo;
-            zerostruct (moduleInfo);
-            moduleInfo.SizeOfStruct = sizeof (moduleInfo);
-
-            if (::SymGetModuleInfo64 (process, symbol->ModBase, &moduleInfo))
-                result << moduleInfo.ModuleName << ": ";
-
-            result << symbol->Name << " + 0x" << String::toHexString (static_cast<int64> (displacement)) << newLine;
-        }
-    }
-
-#else
-    void* stack[128];
-    auto frames = backtrace (stack, numElementsInArray (stack));
-    char** frameStrings = backtrace_symbols (stack, frames);
-
-    for (int i = 0; i < frames; ++i)
-    {
-        Dl_info info;
-        if (dladdr (stack[i], &info))
-        {
-            int status = 0;
-
-            std::unique_ptr<char, decltype (::free)*> demangled (abi::__cxa_demangle (info.dli_sname, nullptr, nullptr, &status), ::free);
-            if (status == 0)
-            {
-                result
-                    << String (i).paddedRight (' ', 3)
-                    << " " << File (String (info.dli_fname)).getFileName().paddedRight (' ', 35)
-                    << " 0x" << String::toHexString (reinterpret_cast<size_t> (stack[i])).paddedLeft ('0', sizeof (void*) * 2)
-                    << " " << demangled.get()
-                    << " + " << (reinterpret_cast<char*> (stack[i]) - reinterpret_cast<char*> (info.dli_saddr)) << newLine;
-
-                continue;
-            }
-        }
-
-        result << frameStrings[i] << newLine;
-    }
-
-    ::free (frameStrings);
-#endif
-
-    return result;
-}
-
-//==============================================================================
-
 void applicationCrashHandler ([[maybe_unused]] void* stackFrame)
 {
-    Logger::getCurrentLogger()->outputDebugString (getStackBacktrace());
+    Logger::getCurrentLogger()->outputDebugString (SystemStats::getStackBacktrace());
 }
 
 } // namespace yup::Helpers

modules/yup_python/utilities/yup_CrashHandling.h

@@ -28,13 +28,6 @@ namespace yup::Helpers
 
 //==============================================================================
 
-/**
- * @brief Obtain stack traces.
- */
-String getStackBacktrace();
-
-//==============================================================================
-
 /**
  * @brief Crash handler.
  */