Skip to content
This repository was archived by the owner on Dec 6, 2019. It is now read-only.

Commit 39aee8d

Browse files
committed
Update to 63.0.3239.30
1 parent 0e7155e commit 39aee8d

File tree

47 files changed

+590
-270
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+590
-270
lines changed

app/src/main/assets/en-US.pak

0 Bytes
Binary file not shown.

app/src/main/assets/resources.pak

685 Bytes
Binary file not shown.

app/src/main/assets/zh-CN.pak

16 Bytes
Binary file not shown.

app/src/main/assets/zh-TW.pak

1 Byte
Binary file not shown.

app/src/main/java/org/chromium/base/ResourceExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class ResourceExtractor {
2626
private static final String TAG = "base";
2727
private static final String ICU_DATA_FILENAME = "icudtl.dat";
2828
private static final String V8_NATIVES_DATA_FILENAME = "natives_blob.bin";
29-
private static final String V8_SNAPSHOT_DATA_FILENAME = "snapshot_blob.bin";
29+
private static final String V8_SNAPSHOT_DATA_FILENAME = "snapshot_blob_32.bin";
3030
private static final String FALLBACK_LOCALE = "en-US";
3131

3232
private class ExtractTask extends AsyncTask<Void, Void, Void> {

app/src/main/java/org/chromium/base/library_loader/NativeLibraries.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ public class NativeLibraries {
88
public static final String[] LIBRARIES =
99
{"chrome"};
1010
static String sVersionNumber =
11-
"63.0.3239.18";
11+
"63.0.3239.30";
1212
}

app/src/main/java/org/chromium/chrome/browser/ActivityTaskDescriptionIconGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ public Bitmap getBitmap(String pageUrl, Bitmap largestFavicon) {
6464
}
6565

6666
if (mGenerator == null) {
67-
mGenerator = new RoundedIconGenerator(mContext, APP_ICON_SIZE_DP, APP_ICON_SIZE_DP,
68-
APP_ICON_CORNER_RADIUS_DP, APP_ICON_DEFAULT_BACKGROUND_COLOR,
67+
mGenerator = new RoundedIconGenerator(mContext.getResources(), APP_ICON_SIZE_DP,
68+
APP_ICON_SIZE_DP, APP_ICON_CORNER_RADIUS_DP, APP_ICON_DEFAULT_BACKGROUND_COLOR,
6969
APP_ICON_TEXT_SIZE_DP);
7070
}
7171

app/src/main/java/org/chromium/chrome/browser/ChromeSwitches.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,6 @@ public abstract class ChromeSwitches {
8181
*/
8282
public static final String DISABLE_TAB_MERGING_FOR_TESTING = "disable-tab-merging";
8383

84-
/**
85-
* Force-enable partner customization for testing.
86-
* Partner customization includes configurations from PartnerBookmarksProvider and
87-
* PartnerBrowserCustomizations.
88-
*/
89-
public static final String ALLOW_PARTNER_CUSTOMIZATION = "allow-partner-customization";
90-
9184
///////////////////////////////////////////////////////////////////////////////////////////////
9285
// Native Switches
9386
///////////////////////////////////////////////////////////////////////////////////////////////

app/src/main/java/org/chromium/chrome/browser/ChromeVersionConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
class ChromeVersionConstants {
88
static final String PRODUCT_NAME = "Chromium";
9-
static final String PRODUCT_VERSION = "63.0.3239.18";
9+
static final String PRODUCT_VERSION = "63.0.3239.30";
1010
static final boolean IS_OFFICIAL_BUILD = 1 == 1;
1111

1212
static final int PRODUCT_MAJOR_VERSION = 63;

app/src/main/java/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ public BookmarkActionBar(Context context, AttributeSet attrs) {
5252
.setTitle(R.string.bookmark_action_bar_move);
5353
getMenu().findItem(R.id.selection_mode_delete_menu_id)
5454
.setTitle(R.string.bookmark_action_bar_delete);
55+
56+
// Wait to enable the selection mode group until the BookmarkDelegate is set. The
57+
// SelectionDelegate is retrieved from the BookmarkDelegate.
58+
getMenu().setGroupEnabled(R.id.selection_mode_menu_group, false);
5559
}
5660

5761
@Override
@@ -68,7 +72,6 @@ public void onNavigationBack() {
6872
public boolean onMenuItemClick(MenuItem menuItem) {
6973
hideOverflowMenu();
7074

71-
SelectionDelegate<BookmarkId> selectionDelegate = mDelegate.getSelectionDelegate();
7275
if (menuItem.getItemId() == R.id.edit_menu_id) {
7376
BookmarkAddEditFolderActivity.startEditFolderActivity(getContext(),
7477
mCurrentFolder.getId());
@@ -79,7 +82,10 @@ public boolean onMenuItemClick(MenuItem menuItem) {
7982
} else if (menuItem.getItemId() == R.id.search_menu_id) {
8083
mDelegate.openSearchUI();
8184
return true;
82-
} else if (menuItem.getItemId() == R.id.selection_mode_edit_menu_id) {
85+
}
86+
87+
SelectionDelegate<BookmarkId> selectionDelegate = mDelegate.getSelectionDelegate();
88+
if (menuItem.getItemId() == R.id.selection_mode_edit_menu_id) {
8389
List<BookmarkId> list = selectionDelegate.getSelectedItems();
8490
assert list.size() == 1;
8591
BookmarkItem item = mDelegate.getModel().getBookmarkById(list.get(0));
@@ -131,10 +137,14 @@ public void onBookmarkDelegateInitialized(BookmarkDelegate delegate) {
131137
mDelegate.addUIObserver(this);
132138
if (!delegate.isDialogUi()) getMenu().removeItem(R.id.close_menu_id);
133139
delegate.getModel().addObserver(mBookmarkModelObserver);
140+
141+
getMenu().setGroupEnabled(R.id.selection_mode_menu_group, true);
134142
}
135143

136144
@Override
137145
public void onDestroy() {
146+
if (mDelegate == null) return;
147+
138148
mDelegate.removeUIObserver(this);
139149
mDelegate.getModel().removeObserver(mBookmarkModelObserver);
140150
}

0 commit comments

Comments
 (0)