Skip to content

Commit 0a58afa

Browse files
committed
fix - prevent invalid message timeouts in persistent subscriptions
1 parent 4175ff3 commit 0a58afa

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

src/js/modules/competing/templates/templates.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/modules/competing/views/subscriptions.item.edit.tpl.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<tr>
3737
<td>Message Timeout (ms)</td>
3838
<td>
39-
<input type="text" ng-model="config.messageTimeoutMilliseconds" class="form-table" name="messageTimeoutMilliseconds" />
39+
<input type="number" min="0" ng-model="config.messageTimeoutMilliseconds" class="form-table" name="messageTimeoutMilliseconds" />
4040
</td>
4141
</tr>
4242
<tr>
@@ -50,49 +50,49 @@
5050
<tr>
5151
<td>Max Retry Count</td>
5252
<td>
53-
<input type="text" ng-model="config.maxRetryCount" class="form-table" name="maxRetryCount" />
53+
<input type="number" min="0" ng-model="config.maxRetryCount" class="form-table" name="maxRetryCount" />
5454
</td>
5555
</tr>
5656
<tr>
5757
<td>Live Buffer Size</td>
5858
<td>
59-
<input type="text" ng-model="config.liveBufferSize" class="form-table" name="liveBufferSize" />
59+
<input type="number" min="0" ng-model="config.liveBufferSize" class="form-table" name="liveBufferSize" />
6060
</td>
6161
</tr>
6262
<tr>
6363
<td>Buffer Size</td>
6464
<td>
65-
<input type="text" ng-model="config.bufferSize" class="form-table" name="bufferSize" />
65+
<input type="number" min="0" ng-model="config.bufferSize" class="form-table" name="bufferSize" />
6666
</td>
6767
</tr>
6868
<tr>
6969
<td>Read Batch Size</td>
7070
<td>
71-
<input type="text" ng-model="config.readBatchSize" class="form-table" name="readBatchSize" />
71+
<input type="number" min="0" ng-model="config.readBatchSize" class="form-table" name="readBatchSize" />
7272
</td>
7373
</tr>
7474
<tr>
7575
<td>CheckPoint After (ms)</td>
7676
<td>
77-
<input type="text" ng-model="config.checkPointAfterMilliseconds" class="form-table" name="checkPointAfterMilliseconds" />
77+
<input type="number" min="0" ng-model="config.checkPointAfterMilliseconds" class="form-table" name="checkPointAfterMilliseconds" />
7878
</td>
7979
</tr>
8080
<tr>
8181
<td>Min CheckPoint Count</td>
8282
<td>
83-
<input type="text" ng-model="config.minCheckPointCount" class="form-table" name="minCheckPointCount" />
83+
<input type="number" min="0" ng-model="config.minCheckPointCount" class="form-table" name="minCheckPointCount" />
8484
</td>
8585
</tr>
8686
<tr>
8787
<td>Max CheckPoint Count</td>
8888
<td>
89-
<input type="text" ng-model="config.maxCheckPointCount" class="form-table" name="maxCheckPointCount" />
89+
<input type="number" min="0" ng-model="config.maxCheckPointCount" class="form-table" name="maxCheckPointCount" />
9090
</td>
9191
</tr>
9292
<tr>
9393
<td>Max Subscriber Count</td>
9494
<td>
95-
<input type="text" ng-model="config.maxSubscriberCount" class="form-table" name="maxSubscriberCount" />
95+
<input type="number" min="0" ng-model="config.maxSubscriberCount" class="form-table" name="maxSubscriberCount" />
9696
</td>
9797
</tr>
9898
<tr>

src/js/modules/competing/views/subscriptions.new.tpl.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ <h2 class="page-title">New Subscription</h2>
4747
<tr>
4848
<td>Message Timeout (ms)</td>
4949
<td>
50-
<input type="text" ng-model="messageTimeoutMilliseconds" class="form-table" name="messageTimeoutMilliseconds" />
50+
<input type="number" min="0" ng-model="messageTimeoutMilliseconds" class="form-table" name="messageTimeoutMilliseconds" />
5151
</td>
5252
</tr>
5353
<tr>
@@ -61,49 +61,49 @@ <h2 class="page-title">New Subscription</h2>
6161
<tr>
6262
<td>Max Retry Count</td>
6363
<td>
64-
<input type="text" ng-model="maxRetryCount" class="form-table" name="maxRetryCount" />
64+
<input type="number" min="0" ng-model="maxRetryCount" class="form-table" name="maxRetryCount" />
6565
</td>
6666
</tr>
6767
<tr>
6868
<td>Live Buffer Size</td>
6969
<td>
70-
<input type="text" ng-model="liveBufferSize" class="form-table" name="liveBufferSize" />
70+
<input type="number" min="0" ng-model="liveBufferSize" class="form-table" name="liveBufferSize" />
7171
</td>
7272
</tr>
7373
<tr>
7474
<td>Buffer Size</td>
7575
<td>
76-
<input type="text" ng-model="bufferSize" class="form-table" name="bufferSize" />
76+
<input type="number" min="0" ng-model="bufferSize" class="form-table" name="bufferSize" />
7777
</td>
7878
</tr>
7979
<tr>
8080
<td>Read Batch Size</td>
8181
<td>
82-
<input type="text" ng-model="readBatchSize" class="form-table" name="readBatchSize" />
82+
<input type="number" min="0" ng-model="readBatchSize" class="form-table" name="readBatchSize" />
8383
</td>
8484
</tr>
8585
<tr>
8686
<td>CheckPoint After (ms)</td>
8787
<td>
88-
<input type="text" ng-model="checkPointAfterMilliseconds" class="form-table" name="checkPointAfterMilliseconds" />
88+
<input type="number" min="0" ng-model="checkPointAfterMilliseconds" class="form-table" name="checkPointAfterMilliseconds" />
8989
</td>
9090
</tr>
9191
<tr>
9292
<td>Min CheckPoint Count</td>
9393
<td>
94-
<input type="text" ng-model="minCheckPointCount" class="form-table" name="minCheckPointCount" />
94+
<input type="number" min="0" ng-model="minCheckPointCount" class="form-table" name="minCheckPointCount" />
9595
</td>
9696
</tr>
9797
<tr>
9898
<td>Max CheckPoint Count</td>
9999
<td>
100-
<input type="text" ng-model="maxCheckPointCount" class="form-table" name="maxCheckPointCount" />
100+
<input type="number" min="0" ng-model="maxCheckPointCount" class="form-table" name="maxCheckPointCount" />
101101
</td>
102102
</tr>
103103
<tr>
104104
<td>Max Subscriber Count</td>
105105
<td>
106-
<input type="text" ng-model="maxSubscriberCount" class="form-table" name="maxSubscriberCount" />
106+
<input type="number" min="0" ng-model="maxSubscriberCount" class="form-table" name="maxSubscriberCount" />
107107
</td>
108108
</tr>
109109
<tr>

0 commit comments

Comments
 (0)