Don't poll for scavenges

- Remove scavengeNotificationService from Run and logIn controllers so
  that the UI no longer polls for scavenge status. This prevents the 404
  messages that show up in the UI if a scavenge has not been run.
- If a 404 is received on the admin screen, stop the scavenge status
  poller.
- Trigger the scavenge status poller if the scavenge button is clicked.
  This will allow the UI to update the scavenge status once a scavenge
  has been triggered.
- If a scavenge was triggered any other way (through curl for example),
  the UI will need to be refreshed to see status updates.

Author: hayley-jean

src/js/modules/admin/controllers/AdminCtrl.js

@@ -10,6 +10,7 @@ define(['./_module'], function (app) {
 
             $scope.noSubSystemsText = 'No sub systems are running.';
             $scope.noScavengeHistoryText = 'No scavenges have been run.';
+            $scope.polling = false;
 
 			adminService.getSubsystems()
 			.then(function(res){
@@ -46,7 +47,9 @@ define(['./_module'], function (app) {
 			$scope.scavenge = function ($event) {
 				stop($event);
 
-				adminService.scavenge().then(null, function (error) {
+				adminService.scavenge().then(function() {
+                                        setupScavengeStatusPoller();
+                                }, function (error) {
 					msg.failure('Scavenge failed: ' + error.message);
 				});
             };
@@ -102,6 +105,10 @@ define(['./_module'], function (app) {
             var scavengeQuery = {};
             var timeout;
             function setupScavengeStatusPoller() {
+                if ($scope.polling === true) {
+                    return;
+                }
+                $scope.polling = true;
                 scavengeQuery = poller.create({
                     interval: constants.scavengeStatus.pollInterval,
                     action: adminService.scavengeStatus,
@@ -113,6 +120,12 @@ define(['./_module'], function (app) {
                     function(error) {
                         if(error.statusCode === 401){
                             $scope.noScavengeHistoryText = 'You are not authorized to view the scavenge history';
+                            $scope.polling = false;
+                            return;
+                        }
+                        if (error.statusCode === 404) {
+                            $scope.noScavengeHistoryText = "No scavenges have been run.";
+                            $scope.polling = false;
                             return;
                         }
                         if(timeout){

src/js/modules/security/controllers/SignInCtrl.js

@@ -3,8 +3,8 @@ define(['./_module'], function (app) {
     'use strict';
 
     return app.controller('SignInCtrl', [
-		'$scope', '$rootScope', '$state', '$location', 'AuthService', 'MessageService', 'InfoService', 'ScavengeNotificationService',
-		function ($scope, $rootScope, $state, $location, authService, msg, infoService, scavengeNotificationService) {
+		'$scope', '$rootScope', '$state', '$location', 'AuthService', 'MessageService', 'InfoService',
+		function ($scope, $rootScope, $state, $location, authService, msg, infoService) {
 
 			$scope.log = {
 				username: '',
@@ -33,7 +33,6 @@ define(['./_module'], function (app) {
 			};
 
 			function setSingleNodeOrCluster(){
-				scavengeNotificationService.start();
 				infoService.getOptions().then(function(res){
 					var options = res.data;
 					for (var index in options) {

src/js/run.js

@@ -8,8 +8,8 @@ define(['es-ui'], function (app) {
         });
     }]);
 	return app.run([
-        '$rootScope', '$location', '$state', '$stateParams', 'AuthService', 'InfoService', 'ScavengeNotificationService', 'MessageService','$http',
-        function ($rootScope, $location, $state, $stateParams, authService, infoService, scavengeNotificationService, msg, $http) {
+        '$rootScope', '$location', '$state', '$stateParams', 'AuthService', 'InfoService', 'MessageService','$http',
+        function ($rootScope, $location, $state, $stateParams, authService, infoService, msg, $http) {
             $rootScope.baseUrl = $location.protocol() + '://' + $location.host() + ':' + $location.port();
             /*$rootScope.baseUrl = 'https://127.0.0.1:2113'; //uncomment during development*/
             $rootScope.projectionsEnabled = false;
@@ -77,7 +77,6 @@ define(['es-ui'], function (app) {
             });
 
             function setSingleNodeOrCluster(){
-                scavengeNotificationService.start();
                 infoService.getOptions().then(function onGetOptions(response){
                     var options = response.data;
                     for (var index in options) {