Refactor: use string builder for error messages, update test name, and add attachment test

Author: kurtmkurtm

src/LiquidTestReports.Core/Mappers/JUnitMapper.cs

@@ -3,10 +3,11 @@
 using LiquidTestReports.Core.Models;
 using System;
 using System.Collections.Generic;
+using System.Text;
 
 namespace LiquidTestReports.Core.Mappers
 {
-    public class JUnitMapper
+    public static class JUnitMapper
     {
         public static void Map(Testsuites source, TestRunDrop destination, ReportInput inputConfiguration = null)
         {
@@ -73,22 +74,20 @@ public static void Map(Testsuites source, TestRunDrop destination, ReportInput i
                     drop.ExecutedTestsCount++;
                     drop.Results.Add(resultDrop);
                 }
-
-
             }
         }
         private static void MapOutputToResult(Testcase test, TestResultDrop drop)
         {
             var messages = new List<TestResultMessageDrop>();
-            var errorMessage = string.Empty;
-            var errorStackTrace = string.Empty;
+            var errorMessage = new StringBuilder();
+            var errorStackTrace = new StringBuilder();
 
             if (test.FailureSpecified)
                 foreach (var failure in test.Failure)                
                     if (!string.IsNullOrEmpty(failure.Message))
                     {
-                        errorMessage += failure.Message;
-                        errorStackTrace += string.Join(Environment.NewLine, failure.Text);
+                        errorMessage.Append(failure.Message);
+                        errorStackTrace.Append(string.Join(Environment.NewLine, failure.Text));
                     }                
 
             if (test.System_OutSpecified)
@@ -102,8 +101,8 @@ private static void MapOutputToResult(Testcase test, TestResultDrop drop)
                         messages.Add(new TestResultMessageDrop { Text = stdErr, Category = "Error" });
 
             drop.Messages = messages;
-            drop.ErrorMessage = errorMessage;
-            drop.ErrorStackTrace = errorStackTrace;
+            drop.ErrorMessage = errorMessage.ToString();
+            drop.ErrorStackTrace = errorStackTrace.ToString();
         }
 
         private static string MapOutcome(Testcase test, TestResultSetDrop setDrop, TestRunStatisticsDrop testRunStatistics)

test/LiquidTestReports.Cli.Tests/ProgramTests.cs

@@ -98,7 +98,7 @@ public void Main_WithTitle_GeneratesReport()
         public void Main_JUnitWithTitle_GeneratesReport()
         {
             //Arrange
-            var title = "My JUnit Tests";
+            var title = "My JUnit + TRX Tests";
             var titleTest = "junitTest.md";
             var destinationReport = new FileInfo(Path.Combine(_outputFolder, titleTest));
             var files = new List<ReportInput>();

test/SampleProject/SampleProject.Tests.MSTest/AttachmentTest.cs

@@ -0,0 +1,21 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using System.IO;
+using System.Reflection;
+
+namespace SampleProject.MSTest
+{
+    [TestClass]
+    public class AttachmentTest
+    {
+        [TestMethod]
+        [TestProperty("ReportName", "Image")]
+        public void AttachImage()
+        {
+            var basePath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
+            TestContext.WriteLine("Attach an image");
+            TestContext.AddResultFile(Path.Combine(basePath, "resources", "attachmentSample.png"));
+            Assert.IsTrue(true);
+        }
+        public TestContext TestContext { get; set; }
+    }
+}

test/SampleProject/SampleProject.Tests.MSTest/Resources/attachmentSample.png

@@ -19,6 +19,9 @@
   </ItemGroup>
 
   <ItemGroup>
+    <None Update="Resources\attachmentSample.png">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Update="Resources\TemplateExample.txt">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

test/SampleProject/SampleProject.Tests.MSTest/SampleProject.MSTest.csproj

@@ -5,7 +5,6 @@ namespace SampleProject.MSTest
     [TestClass]
     public class TestServiceTests
     {
-
         /// <summary>
         ///  Gets or sets the test context which provides
         ///  information about and functionality for the current test run.

test/SampleProject/SampleProject.Tests.MSTest/TestServiceTests.cs

@@ -0,0 +1,20 @@
+using NUnit.Framework;
+using System;
+using System.IO;
+using System.Reflection;
+
+namespace SampleProject.NUnit
+{
+    public class Attachment
+    {
+        [Test]
+        [Category("Image")]
+        public void AttachImage()
+        {
+            var basePath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
+            TestContext.WriteLine("Attach an image");
+            TestContext.AddTestAttachment(Path.Combine(basePath, "resources", "attachmentSample.png"), "screenshot");
+            Assert.True(true);
+        }
+    }
+}

test/SampleProject/SampleProject.Tests.NUnit/AttachmentTest.cs

@@ -22,6 +22,9 @@
   </ItemGroup>
 
   <ItemGroup>
+    <None Update="Resources\attachmentSample.png">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Update="Resources\TemplateExample.txt">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>