nsis: sign uninstaller, maybe

Author: mfisher31

cmake/CodeSign.cmake

@@ -121,7 +121,7 @@ elseif(WIN32)
                 /td SHA256 
                 /dlib "${TRUSTED_SIGNING_DLIB}" 
                 /dmdf "${METADATA_FILE}")
-            set(SIGNTOOL_CMD "${SIGNTOOL_CMD}" PARENT_SCOPE)
+            # set(SIGNTOOL_CMD "${SIGNTOOL_CMD}" PARENT_SCOPE)
 
             add_custom_target(sign-products
                 COMMAND ${SIGNTOOL_CMD} "${VST3_BINARY}"

cmake/Packaging.cmake

@@ -40,6 +40,13 @@ elseif(WIN32)
         set(CPACK_NSIS_CLAP_INSTALL_DIRECTORY "$COMMONFILES64\\\\CLAP")
         set(CPACK_NSIS_LV2_INSTALL_DIRECTORY "$COMMONFILES64\\\\LV2")
         set(CPACK_NSIS_VST3_INSTALL_DIRECTORY "$COMMONFILES64\\\\VST3")
+
+        # Sign the uninstaller using !uninstfinalize
+        if(SIGNTOOL_CMD)
+            message(STATUS "NSIS: sign uninstaller")
+            string(REPLACE ";" " " SIGNTOOL_CMD_STR "${SIGNTOOL_CMD}")
+            set(CPACK_NSIS_DEFINES "!uninstfinalize '${SIGNTOOL_CMD_STR} \"%1\"'")
+        endif()
     else()
         set(CPACK_GENERATOR "ZIP")
         set(CPACK_SET_DESTDIR OFF)