From 3319582773d8701d9756acdc799369cca714ca6a Mon Sep 17 00:00:00 2001 From: iBenzene Date: Sat, 25 Oct 2025 17:53:32 +0800 Subject: [PATCH 1/2] fix(transfer_engine): Add notify callback registration in RPC metadata handling --- mooncake-transfer-engine/src/transfer_metadata.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/mooncake-transfer-engine/src/transfer_metadata.cpp b/mooncake-transfer-engine/src/transfer_metadata.cpp index 04c6964ac..83db821f2 100644 --- a/mooncake-transfer-engine/src/transfer_metadata.cpp +++ b/mooncake-transfer-engine/src/transfer_metadata.cpp @@ -608,14 +608,19 @@ int TransferMetadata::addRpcMetaEntry(const std::string &server_name, local_rpc_meta_ = desc; if (p2p_handshake_mode_) { - int rc = handshake_plugin_->startDaemon(desc.rpc_port, desc.sockfd); - if (rc != 0) { - return rc; - } handshake_plugin_->registerOnMetadataCallBack( [this](const Json::Value &peer, Json::Value &local) -> int { return receivePeerMetadata(peer, local); }); + handshake_plugin_->registerOnNotifyCallBack( + [this](const Json::Value &peer, Json::Value &local) -> int { + return receivePeerNotify(peer, local); + }); + + int rc = handshake_plugin_->startDaemon(desc.rpc_port, desc.sockfd); + if (rc != 0) { + return rc; + } return 0; } From 2a8bcdf8edb4a105a1f20c7b957e9e8bab4a027d Mon Sep 17 00:00:00 2001 From: iBenzene Date: Sun, 26 Oct 2025 01:50:39 +0800 Subject: [PATCH 2/2] chore(transfer_metadata): Remove unnecessary spaces or tabs --- mooncake-transfer-engine/src/transfer_metadata.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mooncake-transfer-engine/src/transfer_metadata.cpp b/mooncake-transfer-engine/src/transfer_metadata.cpp index 83db821f2..5a0ce799f 100644 --- a/mooncake-transfer-engine/src/transfer_metadata.cpp +++ b/mooncake-transfer-engine/src/transfer_metadata.cpp @@ -616,7 +616,7 @@ int TransferMetadata::addRpcMetaEntry(const std::string &server_name, [this](const Json::Value &peer, Json::Value &local) -> int { return receivePeerNotify(peer, local); }); - + int rc = handshake_plugin_->startDaemon(desc.rpc_port, desc.sockfd); if (rc != 0) { return rc;