|
21 | 21 | #include <util/thread.h> |
22 | 22 | #include <util/time.h> |
23 | 23 | #include <util/underlying.h> |
| 24 | +#include <validation.h> |
24 | 25 |
|
25 | 26 | #include <cxxtimer.hpp> |
26 | 27 |
|
@@ -179,10 +180,11 @@ void CSigSharesNodeState::RemoveSession(const uint256& signHash) |
179 | 180 |
|
180 | 181 | ////////////////////// |
181 | 182 |
|
182 | | -CSigSharesManager::CSigSharesManager(CConnman& connman, CSigningManager& _sigman, PeerManager& peerman, |
183 | | - const CActiveMasternodeManager& mn_activeman, const CQuorumManager& _qman, |
184 | | - const CSporkManager& sporkman) : |
| 183 | +CSigSharesManager::CSigSharesManager(CConnman& connman, CChainState& chainstate, CSigningManager& _sigman, |
| 184 | + PeerManager& peerman, const CActiveMasternodeManager& mn_activeman, |
| 185 | + const CQuorumManager& _qman, const CSporkManager& sporkman) : |
185 | 186 | m_connman{connman}, |
| 187 | + m_chainstate{chainstate}, |
186 | 188 | sigman{_sigman}, |
187 | 189 | m_peerman{peerman}, |
188 | 190 | m_mn_activeman{mn_activeman}, |
@@ -866,6 +868,86 @@ CDeterministicMNCPtr CSigSharesManager::SelectMemberForRecovery(const CQuorumCPt |
866 | 868 | return v[attempt % v.size()].second; |
867 | 869 | } |
868 | 870 |
|
| 871 | +bool CSigSharesManager::AsyncSignIfMember(Consensus::LLMQType llmqType, CSigningManager& sigman, const uint256& id, |
| 872 | + const uint256& msgHash, const uint256& quorumHash, bool allowReSign, |
| 873 | + bool allowDiffMsgHashSigning) |
| 874 | +{ |
| 875 | + AssertLockNotHeld(cs_pendingSigns); |
| 876 | + |
| 877 | + if (m_mn_activeman.GetProTxHash().IsNull()) return false; |
| 878 | + |
| 879 | + const auto quorum = [&]() { |
| 880 | + if (quorumHash.IsNull()) { |
| 881 | + // This might end up giving different results on different members |
| 882 | + // This might happen when we are on the brink of confirming a new quorum |
| 883 | + // This gives a slight risk of not getting enough shares to recover a signature |
| 884 | + // But at least it shouldn't be possible to get conflicting recovered signatures |
| 885 | + // TODO fix this by re-signing when the next block arrives, but only when that block results in a change of |
| 886 | + // the quorum list and no recovered signature has been created in the mean time |
| 887 | + const auto& llmq_params_opt = Params().GetLLMQ(llmqType); |
| 888 | + assert(llmq_params_opt.has_value()); |
| 889 | + return SelectQuorumForSigning(llmq_params_opt.value(), m_chainstate.m_chain, qman, id); |
| 890 | + } else { |
| 891 | + return qman.GetQuorum(llmqType, quorumHash); |
| 892 | + } |
| 893 | + }(); |
| 894 | + |
| 895 | + if (!quorum) { |
| 896 | + LogPrint(BCLog::LLMQ, "CSigningManager::%s -- failed to select quorum. id=%s, msgHash=%s\n", __func__, |
| 897 | + id.ToString(), msgHash.ToString()); |
| 898 | + return false; |
| 899 | + } |
| 900 | + |
| 901 | + if (!quorum->IsValidMember(m_mn_activeman.GetProTxHash())) { |
| 902 | + return false; |
| 903 | + } |
| 904 | + |
| 905 | + { |
| 906 | + auto& db = sigman.GetDb(); |
| 907 | + bool hasVoted = db.HasVotedOnId(llmqType, id); |
| 908 | + if (hasVoted) { |
| 909 | + uint256 prevMsgHash; |
| 910 | + db.GetVoteForId(llmqType, id, prevMsgHash); |
| 911 | + if (msgHash != prevMsgHash) { |
| 912 | + if (allowDiffMsgHashSigning) { |
| 913 | + LogPrintf("%s -- already voted for id=%s and msgHash=%s. Signing for different " /* Continued */ |
| 914 | + "msgHash=%s\n", |
| 915 | + __func__, id.ToString(), prevMsgHash.ToString(), msgHash.ToString()); |
| 916 | + hasVoted = false; |
| 917 | + } else { |
| 918 | + LogPrintf("%s -- already voted for id=%s and msgHash=%s. Not voting on " /* Continued */ |
| 919 | + "conflicting msgHash=%s\n", |
| 920 | + __func__, id.ToString(), prevMsgHash.ToString(), msgHash.ToString()); |
| 921 | + return false; |
| 922 | + } |
| 923 | + } else if (allowReSign) { |
| 924 | + LogPrint(BCLog::LLMQ, "%s -- already voted for id=%s and msgHash=%s. Resigning!\n", __func__, |
| 925 | + id.ToString(), prevMsgHash.ToString()); |
| 926 | + } else { |
| 927 | + LogPrint(BCLog::LLMQ, "%s -- already voted for id=%s and msgHash=%s. Not voting again.\n", __func__, |
| 928 | + id.ToString(), prevMsgHash.ToString()); |
| 929 | + return false; |
| 930 | + } |
| 931 | + } |
| 932 | + |
| 933 | + if (db.HasRecoveredSigForId(llmqType, id)) { |
| 934 | + // no need to sign it if we already have a recovered sig |
| 935 | + return true; |
| 936 | + } |
| 937 | + if (!hasVoted) { |
| 938 | + db.WriteVoteForId(llmqType, id, msgHash); |
| 939 | + } |
| 940 | + } |
| 941 | + |
| 942 | + if (allowReSign) { |
| 943 | + // make us re-announce all known shares (other nodes might have run into a timeout) |
| 944 | + ForceReAnnouncement(quorum, llmqType, id, msgHash); |
| 945 | + } |
| 946 | + AsyncSign(quorum, id, msgHash); |
| 947 | + |
| 948 | + return true; |
| 949 | +} |
| 950 | + |
869 | 951 | void CSigSharesManager::CollectSigSharesToRequest(std::unordered_map<NodeId, Uint256HashMap<CSigSharesInv>>& sigSharesToRequest) |
870 | 952 | { |
871 | 953 | AssertLockHeld(cs); |
|
0 commit comments