Static call to instance method Carbon\Carbon::setHolidays()

[sojeda]

Hi, I’m using the package with PHPStan. I added the exception, but after doing that I’m getting the following errors.

Carbon::setHolidays('us', $holidays);
CarbonImmutable::setHolidays('us', $holidays);

Carbon::setHolidaysRegion('us');
CarbonImmutable::setHolidaysRegion('us');

Phpstan

  41     Static call to instance method Carbon\Carbon::setHolidays().                 
         🪪  method.staticCall                                                        
         at app/Providers/HolidaysServiceProvider.php:41                   
  42     Static call to instance method Carbon\CarbonImmutable::setHolidays().        
         🪪  method.staticCall                                                        
         at app/Providers/HolidaysServiceProvider.php:42                   
  44     Static call to instance method Carbon\Carbon::setHolidaysRegion().           
         🪪  method.staticCall                                                        
         at app/Providers/HolidaysServiceProvider.php:44                   
  45     Static call to instance method Carbon\CarbonImmutable::setHolidaysRegion().  
         🪪  method.staticCall                                                        
         at app/Providers/HolidaysServiceProvider.php:45   

Any ideas?

No, I’m not sure if this case is covered by

- ./vendor/cmixin/business-day/extension.neon

Or am I doing something wrong?

[kylekatarnls]

Hello. It should be covered by the extension.neon because we have:

public static function setHolidays($region, $holidays)

In https://github.com/kylekatarnls/business-day/blob/master/types/_ide_business_day_static.php#L597

(Where the method is static)

But macros being available as both, it's also listed as an instance method in
https://github.com/kylekatarnls/business-day/blob/master/types/_ide_business_day_instantiated.php#L597

I think PHPStan was previously able to detect that a macro is allowed as static, instance or both, but maybe it's no longer the case.

[endelwar]

I've the same issue, but if I enable vendor/cmixin/business-day/extension.neon I get a crash on PHPStan 2.1.33

 ------ ---------------------------------------------------------------------
  Line   Controller/Admin/Orari/FestivitaController.php
 ------ ---------------------------------------------------------------------
  95     Call to an undefined static method Carbon\Carbon::getHolidayName().
         🪪  staticMethod.notFound
         ✏️  Controller/Admin/Orari/FestivitaController.php
  177    Call to an undefined static method Carbon\Carbon::getHolidayName().
         🪪  staticMethod.notFound
         ✏️  Controller/Admin/Orari/FestivitaController.php
 ------ ---------------------------------------------------------------------

on both lines I have

$holiday::getHolidayName(locale: 'it_IT')

Internal error: An optional parameter $date must have a default value while analysing file /Users/me/Sites/myapp/src/Controller/Admin/Orari/FestivitaController.php

 ## phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/ArgumentsNormalizer.php(205)
 #0 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/ArgumentsNormalizer.php(96):
 PHPStan\Analyser\ArgumentsNormalizer::reorderArgs(Object(PHPStan\Reflection\ResolvedFunctionVariantWithOriginal), Array)
 #1 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(3995):
 PHPStan\Analyser\ArgumentsNormalizer::reorderStaticCallArguments(Object(PHPStan\Reflection\ResolvedFunctionVariantWithOriginal),
 Object(PhpParser\Node\Expr\StaticCall))
 #2 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1613):
 PHPStan\Analyser\MutatingScope->methodCallReturnType(Object(PHPStan\Type\ObjectType), 'getHolidayName',
 Object(PhpParser\Node\Expr\StaticCall))
 #3 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(642):
 PHPStan\Analyser\MutatingScope->resolveType('$holiday::getHo...', Object(PhpParser\Node\Expr\StaticCall))
 #4 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(4141):
 PHPStan\Analyser\MutatingScope->getType(Object(PhpParser\Node\Expr\StaticCall))
 #5 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(2321):
 PHPStan\Analyser\NodeScopeResolver->processArgs(Object(PhpParser\Node\Stmt\Expression), Object(PHPStan\Reflection\ResolvedMethodReflection),
 Object(PHPStan\Reflection\Php\PhpMethodReflection), Object(PHPStan\Reflection\ResolvedFunctionVariantWithOriginal),
 Object(PhpParser\Node\Expr\MethodCall), Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\ExpressionContext))
 #6 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(791):
 PHPStan\Analyser\NodeScopeResolver->processExprNode(Object(PhpParser\Node\Stmt\Expression), Object(PhpParser\Node\Expr\MethodCall),
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\ExpressionContext))
 #7 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Expression), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #8 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1060):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\Foreach_), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #9 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Foreach_), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #10 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(687):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\ClassMethod), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #11 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(5254):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\ClassMethod), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #12 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(5270):
 PHPStan\Analyser\NodeScopeResolver->processNodesForCalledMethod(Object(PhpParser\Node\Stmt\Class_), '/Users/me/S...',
 Object(PHPStan\Reflection\ResolvedMethodReflection), Object(Closure))
 #13 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(5266):
 PHPStan\Analyser\NodeScopeResolver->processNodesForCalledMethod(Array, '/Users/me/S...',
 Object(PHPStan\Reflection\ResolvedMethodReflection), Object(Closure))
 #14 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(5270):
 PHPStan\Analyser\NodeScopeResolver->processNodesForCalledMethod(Object(PhpParser\Node\Stmt\Namespace_), '/Users/me/S...',
 Object(PHPStan\Reflection\ResolvedMethodReflection), Object(Closure))
 #15 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(5192):
 PHPStan\Analyser\NodeScopeResolver->processNodesForCalledMethod(Array, '/Users/me/S...',
 Object(PHPStan\Reflection\ResolvedMethodReflection), Object(Closure))
 #16 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(2336):
 PHPStan\Analyser\NodeScopeResolver->processCalledMethod(Object(PHPStan\Reflection\ResolvedMethodReflection))
 #17 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(791):
 PHPStan\Analyser\NodeScopeResolver->processExprNode(Object(PhpParser\Node\Stmt\Expression), Object(PhpParser\Node\Expr\MethodCall),
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\ExpressionContext))
 #18 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Expression), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #19 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(947):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\If_), Array, Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #20 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\If_), Object(PHPStan\Analyser\MutatingScope), Object(Closure),
 Object(PHPStan\Analyser\StatementContext))
 #21 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1060):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\Foreach_), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #22 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Foreach_), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #23 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(687):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\ClassMethod), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #24 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\ClassMethod), Object(PHPStan\Analyser\MutatingScope),
 Object(class@anonymous), Object(PHPStan\Analyser\StatementContext))
 #25 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(891):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\Class_), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(class@anonymous), Object(PHPStan\Analyser\StatementContext))
 #26 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Class_), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #27 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(822):
 PHPStan\Analyser\NodeScopeResolver->processStmtNodesInternal(Object(PhpParser\Node\Stmt\Namespace_), Array,
 Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #28 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(434):
 PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Namespace_), Object(PHPStan\Analyser\MutatingScope),
 Object(Closure), Object(PHPStan\Analyser\StatementContext))
 #29 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(221):
 PHPStan\Analyser\NodeScopeResolver->processNodes(Array, Object(PHPStan\Analyser\MutatingScope), Object(Closure))
 #30 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/WorkerCommand.php(149):
 PHPStan\Analyser\FileAnalyser->analyseFile('/Users/me/S...', Array, Object(PHPStan\Rules\LazyRegistry),
 Object(PHPStan\Collectors\Registry), NULL)
 #31
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/EventEmitterTrait.php
 (111): PHPStan\Command\WorkerCommand::PHPStan\Command\{closure}(Array)
 #32 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/clue/ndjson-react/src/Decoder.php(117):
 _PHPStan_5adafcbb8\Evenement\EventEmitter->emit('data', Array)
 #33
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/EventEmitterTrait.php
 (111): _PHPStan_5adafcbb8\Clue\React\NDJson\Decoder->handleData(Array)
 #34 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/react/stream/src/Util.php(62):
 _PHPStan_5adafcbb8\Evenement\EventEmitter->emit('data', Array)
 #35
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/EventEmitterTrait.php
 (111): _PHPStan_5adafcbb8\React\Stream\Util::_PHPStan_5adafcbb8\React\Stream\{closure}('{"action":"anal...')
 #36
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/react/stream/src/DuplexResourceStream.php(168
 ): _PHPStan_5adafcbb8\Evenement\EventEmitter->emit('data', Array)
 #37
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/react/event-loop/src/StreamSelectLoop.php(201
 ): _PHPStan_5adafcbb8\React\Stream\DuplexResourceStream->handleData(Resource id #6459)
 #38
 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/react/event-loop/src/StreamSelectLoop.php(173
 ): _PHPStan_5adafcbb8\React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)
 #39 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/WorkerCommand.php(105):
 _PHPStan_5adafcbb8\React\EventLoop\StreamSelectLoop->run()
 #40 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(259):
 PHPStan\Command\WorkerCommand->execute(Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Input\ArgvInput),
 Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Output\ConsoleOutput))
 #41 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(868):
 _PHPStan_5adafcbb8\Symfony\Component\Console\Command\Command->run(Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Input\ArgvInput),
 Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Output\ConsoleOutput))
 #42 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(261):
 _PHPStan_5adafcbb8\Symfony\Component\Console\Application->doRunCommand(Object(PHPStan\Command\WorkerCommand),
 Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Input\ArgvInput),
 Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Output\ConsoleOutput))
 #43 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(157):
 _PHPStan_5adafcbb8\Symfony\Component\Console\Application->doRun(Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Input\ArgvInput),
 Object(_PHPStan_5adafcbb8\Symfony\Component\Console\Output\ConsoleOutput))
 #44 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(99):
 _PHPStan_5adafcbb8\Symfony\Component\Console\Application->run()
 #45 phar:///Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(100): _PHPStan_5adafcbb8\{closure}()
 #46 /Users/me/Sites/myapp/tools/phpstan/vendor/phpstan/phpstan/phpstan(8): require('phar:///Users/m...')
 #47 /Users/me/Sites/myapp/tools/phpstan/vendor/bin/phpstan(119): include('/Users/me/S...')
 #48 {main}