Skip to content

Commit 585fff3

Browse files
authored
fix: Remove unnecessary filter for preloaded Community Modules (#4678)
* fix: Remove unnecesary filter * change || to &&
1 parent 8b10371 commit 585fff3

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/components/Modules/providers/ModuleTemplatesProvider.jsx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,10 @@ export function ModuleTemplatesContextProvider({ children }) {
2828

2929
let checkedModuleTemplates;
3030

31-
if (!moduleTemplatesLoading || !communityModuleTemplatesLoading)
32-
checkedModuleTemplates = externalCommunityModuleTemplates
33-
.filter((resource) => {
34-
if (allModuleTemplates?.items !== undefined)
35-
return !allModuleTemplates.items.some(
36-
(mt) =>
37-
mt.metadata?.name === resource.value?.metadata?.name &&
38-
mt.spec?.version === resource.value?.spec?.version,
39-
);
40-
return resource.value;
41-
})
42-
.flatMap((res) => res.value);
31+
if (!moduleTemplatesLoading && !communityModuleTemplatesLoading)
32+
checkedModuleTemplates = externalCommunityModuleTemplates.flatMap(
33+
(res) => res.value,
34+
);
4335

4436
const mergedModuleTmeplates = {
4537
items: [

0 commit comments

Comments
 (0)