Cover case when the current-context is missing (#2601) (#2613)

Co-authored-by: Filip Strozik <[email protected]>

Author: kwiatekus

internal/kubeconfig/kubeconfig.go

@@ -36,8 +36,7 @@ func PrepareWithToken(apiBase *api.Config, token string) *api.Config {
 }
 
 func Prepare(ctx context.Context, client kube.Client, name, namespace, time, output string, permanent bool) (*api.Config, clierror.Error) {
-	currentCtx := client.APIConfig().CurrentContext
-	clusterName := client.APIConfig().Contexts[currentCtx].Cluster
+	clusterName := getKubeconfigCurrentClusterName(client.APIConfig())
 	var tokenData authv1.TokenRequestStatus
 	var certData []byte
 	var err clierror.Error
@@ -85,22 +84,21 @@ func Prepare(ctx context.Context, client kube.Client, name, namespace, time, out
 			},
 		},
 		Contexts: map[string]*api.Context{
-			currentCtx: {
+			clusterName: {
 				Cluster:   clusterName,
 				Namespace: namespace,
 				AuthInfo:  name,
 			},
 		},
-		CurrentContext: currentCtx,
+		CurrentContext: clusterName,
 		Extensions:     nil,
 	}
 
 	return kubeconfig, nil
 }
 
 func PrepareFromOpenIDConnectorResource(ctx context.Context, client kube.Client, name string) (*api.Config, clierror.Error) {
-	currentCtx := client.APIConfig().CurrentContext
-	clusterName := client.APIConfig().Contexts[currentCtx].Cluster
+	clusterName := getKubeconfigCurrentClusterName(client.APIConfig())
 
 	oidcResUnstruct, err := client.Dynamic().Resource(OpenIdConnectGVR).Get(ctx, name, metav1.GetOptions{})
 	if err != nil {
@@ -137,18 +135,33 @@ func PrepareFromOpenIDConnectorResource(ctx context.Context, client kube.Client,
 			},
 		},
 		Contexts: map[string]*api.Context{
-			currentCtx: {
+			clusterName: {
 				Cluster:  clusterName,
 				AuthInfo: name,
 			},
 		},
-		CurrentContext: currentCtx,
+		CurrentContext: clusterName,
 		Extensions:     nil,
 	}
 
 	return kubeconfig, nil
 }
 
+func getKubeconfigCurrentClusterName(kubeconfig *api.Config) string {
+	clusterName := kubeconfig.CurrentContext
+	if clusterName != "" {
+		// current context exists
+		return kubeconfig.Contexts[kubeconfig.CurrentContext].Cluster
+	}
+
+	// get first cluster from map
+	for clusterName = range kubeconfig.Clusters {
+		break
+	}
+
+	return clusterName
+}
+
 func unmarshalOIDCResource(obj map[string]any) (OpenIDConnect, error) {
 	var oidc OpenIDConnect
 	b, err := json.Marshal(obj)

internal/kubeconfig/kubeconfig_test.go

@@ -113,13 +113,13 @@ func Test_Prepare(t *testing.T) {
 					},
 				},
 				Contexts: map[string]*api.Context{
-					"context": {
+					"cluster": {
 						Cluster:   "cluster",
 						AuthInfo:  "username",
 						Namespace: "default",
 					},
 				},
-				CurrentContext: "context",
+				CurrentContext: "cluster",
 			},
 			expectedErr: nil,
 		},
@@ -146,13 +146,13 @@ func Test_Prepare(t *testing.T) {
 					},
 				},
 				Contexts: map[string]*api.Context{
-					"context": {
+					"cluster": {
 						Cluster:   "cluster",
 						AuthInfo:  "username",
 						Namespace: "default",
 					},
 				},
-				CurrentContext: "context",
+				CurrentContext: "cluster",
 			},
 			expectedErr: nil,
 		},
@@ -194,11 +194,11 @@ func Test_Prepare(t *testing.T) {
 					},
 				},
 				Contexts: map[string]*api.Context{
-					"context": {
+					"cluster": {
 						Cluster: "cluster",
 					},
 				},
-				CurrentContext: "context",
+				CurrentContext: "cluster",
 			}
 
 			staticClient := k8s_fake.NewSimpleClientset(
@@ -414,13 +414,70 @@ func Test_PrepareFromOpenIDConnectorResource(t *testing.T) {
 					},
 				},
 			},
+			Contexts: map[string]*api.Context{
+				"cluster": {
+					Cluster:  "cluster",
+					AuthInfo: "kyma-oidc",
+				},
+			},
+			CurrentContext: "cluster",
+			Extensions:     nil,
+		}
+		require.Equal(t, expected, result)
+	})
+
+	t.Run("kubeconfig without current context", func(t *testing.T) {
+		apiConfig := &api.Config{
+			Clusters: map[string]*api.Cluster{
+				"cluster": {
+					Server:                   "https://localhost:8080",
+					CertificateAuthorityData: []byte("certificate"),
+				},
+			},
 			Contexts: map[string]*api.Context{
 				"context": {
+					Cluster: "cluster",
+				},
+			},
+			CurrentContext: "",
+		}
+		fakeClient := newFakeClient(baseOIDCRes)
+		fakeClient.TestAPIConfig = apiConfig
+
+		result, clierr := PrepareFromOpenIDConnectorResource(context.Background(), fakeClient, "kyma-oidc")
+		require.Nil(t, clierr)
+
+		expected := &api.Config{
+			Kind:       "Config",
+			APIVersion: "v1",
+			Clusters: map[string]*api.Cluster{
+				"cluster": {
+					Server:                   "https://localhost:8080",
+					CertificateAuthorityData: []byte("certificate"),
+				},
+			},
+			AuthInfos: map[string]*api.AuthInfo{
+				"kyma-oidc": {
+					Exec: &api.ExecConfig{
+						APIVersion: "client.authentication.k8s.io/v1beta1",
+						Command:    "kubectl-oidc_login",
+						Args: []string{
+							"get-token",
+							"--oidc-issuer-url=http://super.issuer.com",
+							"--oidc-client-id=10033344-6d08-46cd-80b9-37e18cd856c1",
+							"--oidc-extra-scope=email",
+							"--oidc-extra-scope=openid",
+						},
+					},
+				},
+			},
+			Contexts: map[string]*api.Context{
+				"cluster": {
 					Cluster:  "cluster",
 					AuthInfo: "kyma-oidc",
 				},
 			},
-			CurrentContext: "context",
+			CurrentContext: "cluster",
 			Extensions:     nil,
 		}
 		require.Equal(t, expected, result)