Added community modules existence validation (#2572)

Author: musztardem

internal/cmd/module/add.go

@@ -89,6 +89,7 @@ func loadCustomCRs(crPath string) ([]unstructured.Unstructured, clierror.Error)
 
 func addModule(cfg *addConfig, client *kube.Client, crs ...unstructured.Unstructured) clierror.Error {
 	moduleTemplatesRepo := repo.NewModuleTemplatesRepo(*client)
+
 	if cfg.community {
 		return installCommunityModule(cfg, client, moduleTemplatesRepo, crs...)
 	}
@@ -97,6 +98,11 @@ func addModule(cfg *addConfig, client *kube.Client, crs ...unstructured.Unstruct
 }
 
 func installCommunityModule(cfg *addConfig, client *kube.Client, repo repo.ModuleTemplatesRepository, crs ...unstructured.Unstructured) clierror.Error {
+	err := modules.VerifyModuleExistence(cfg.Ctx, cfg.module, cfg.version, repo)
+	if err != nil {
+		return clierror.Wrap(err, clierror.New("failed to install the community module"))
+	}
+
 	fmt.Println("Warning:\n  You are about to install a community module.\n" +
 		"  Community modules are not officially supported and come with no binding Service Level Agreement (SLA).\n" +
 		"  There is no guarantee of support, maintenance, or compatibility.")

internal/modules/install.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"slices"
 	"strings"
 	"time"
 
@@ -46,6 +47,40 @@ func Install(ctx context.Context, client kube.Client, repo repo.ModuleTemplatesR
 	return nil
 }
 
+func VerifyModuleExistence(ctx context.Context, moduleName, version string, repo repo.ModuleTemplatesRepository) error {
+	communityModules, err := repo.Community(ctx)
+	if err != nil {
+		return fmt.Errorf("failed to retrieve community modules: %v", err)
+	}
+
+	var existingModules []kyma.ModuleTemplate
+
+	for _, communityModule := range communityModules {
+		if communityModule.Spec.ModuleName == moduleName {
+			existingModules = append(existingModules, communityModule)
+		}
+	}
+
+	if len(existingModules) == 0 {
+		return fmt.Errorf("community module %s is not available in the catalog", moduleName)
+	}
+
+	if version == "" {
+		return nil
+	}
+
+	var availableVersions []string
+	for _, module := range existingModules {
+		availableVersions = append(availableVersions, module.Spec.Version)
+	}
+
+	if !slices.Contains(availableVersions, version) {
+		return fmt.Errorf("community module %s in version %s does not exist. Available versions: %s", moduleName, version, strings.Join(availableVersions, ", "))
+	}
+
+	return nil
+}
+
 func applyCustomResources(ctx context.Context, client kube.Client, existingModule *kyma.ModuleTemplate, data InstallCommunityModuleData) error {
 	if data.IsDefaultCRApplicable && len(data.CustomResources) > 0 {
 		return fmt.Errorf("default custom resource and custom resources list cannot be applied together")

internal/modules/install_test.go

@@ -258,6 +258,61 @@ func TestInstall_ModuleSuccessfullyInstalledWithCustomCR(t *testing.T) {
 	require.Nil(t, clierr)
 }
 
+func TestVerifyModuleExistence(t *testing.T) {
+	ctx := context.Background()
+	moduleName := "test-module"
+	version := "1.0.0"
+
+	t.Run("module not found", func(t *testing.T) {
+		repo := modulesfake.ModuleTemplatesRepo{
+			ReturnCommunity: []kyma.ModuleTemplate{},
+		}
+		err := VerifyModuleExistence(ctx, moduleName, version, &repo)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "module test-module is not available in the catalog")
+	})
+
+	t.Run("version not found", func(t *testing.T) {
+		repo := modulesfake.ModuleTemplatesRepo{
+			ReturnCommunity: []kyma.ModuleTemplate{
+				{Spec: kyma.ModuleTemplateSpec{ModuleName: moduleName, Version: "2.0.0"}},
+			},
+		}
+		err := VerifyModuleExistence(ctx, moduleName, version, &repo)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "community module test-module in version 1.0.0 does not exist. Available versions: 2.0.0")
+	})
+
+	t.Run("version found", func(t *testing.T) {
+		repo := modulesfake.ModuleTemplatesRepo{
+			ReturnCommunity: []kyma.ModuleTemplate{
+				{Spec: kyma.ModuleTemplateSpec{ModuleName: moduleName, Version: version}},
+			},
+		}
+		err := VerifyModuleExistence(ctx, moduleName, version, &repo)
+		require.NoError(t, err)
+	})
+
+	t.Run("version empty (any version is valid)", func(t *testing.T) {
+		repo := modulesfake.ModuleTemplatesRepo{
+			ReturnCommunity: []kyma.ModuleTemplate{
+				{Spec: kyma.ModuleTemplateSpec{ModuleName: moduleName, Version: "2.0.0"}},
+			},
+		}
+		err := VerifyModuleExistence(ctx, moduleName, "", &repo)
+		require.NoError(t, err)
+	})
+
+	t.Run("repo error", func(t *testing.T) {
+		repo := modulesfake.ModuleTemplatesRepo{
+			CommunityErr: errors.New("repo error"),
+		}
+		err := VerifyModuleExistence(ctx, moduleName, version, &repo)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "failed to retrieve community modules: repo error")
+	})
+}
+
 func getTestHttpServerWithResponse(response string) *httptest.Server {
 	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		_, _ = w.Write([]byte(response))