-
Notifications
You must be signed in to change notification settings - Fork 32
Description
Description
We still support the old way of listing all the ModuleTemplates and then filtering them by the channel if there is no ModuleReleaseMeta existing for this module. After all modules teams have their ModuleReleaseMeta CRs deployed to the KCP, we need to remove this old code.
Reasons
No response
Acceptance Criteria
- Remove the code which lists all ModuleTemplates and only support the usage of ModuleReleaseMeta
-
Remove the old E2E tests which run without the ModuleReleaseMeta - Refector by_module_release_meta_strategy.go for all module, including mandatory module.
- Remove mandatory moduletemplate lookup: https://github.com/kyma-project/lifecycle-manager/blob/6ccede3f8a9b1bac517bcfb433546a2364a9cc19/pkg/templatelookup/mandatory.go
Feature Testing
No response
Testing approach
No response
DevNotes:
The github action relies on old ModuleTemplates can be dropped complete:
https://github.com/kyma-project/lifecycle-manager/tree/df391286f3d549c1625f39bafb5276766e4fe602/.github/actions/deploy-template-operator
All old ModuleTemplates for e2e tests can be dropped: https://github.com/kyma-project/lifecycle-manager/tree/8da47c078172a56a632c3bd6ebb2063792fbfa54/tests/e2e/moduletemplate
After this change, only by_module_release_meta_strategy.go will be used. There is no need to keep this strategy pattern.