Skip to content

Commit ae1c186

Browse files
committed
fix: refactor login error handling logic
- Change login logic to raise an error when the user is not found instead of when the user is found. - Remove unnecessary else statement after user check. Signed-off-by: kyo <[email protected]>
1 parent aaafb09 commit ae1c186

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

user/api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ def login_user(request: HttpRequest, payload: LoginRequest) -> dict[str, str]:
6060
登入使用者
6161
"""
6262
user = authenticate(request, username=payload.username, password=payload.password)
63-
if user is not None:
64-
login(request, user) # 將使用者登入狀態保存至 session
65-
return {'message': '登入成功'}
66-
else:
63+
if user is None:
6764
raise HttpError(401, '帳號或密碼錯誤')
65+
66+
login(request, user) # 將使用者登入狀態保存至 session
67+
return {'message': '登入成功'}

0 commit comments

Comments
 (0)