follow the custom that load's argument is file pointer, which reduces the responsibility to load file from config class

Author: kyuridenamida

atcodertools/codegen/code_gen_config.py

@@ -1,3 +1,5 @@
+from typing import TextIO
+
 import toml
 
 INDENT_TYPE_SPACE = 'space'
@@ -29,7 +31,6 @@ def indent(self, depth):
         return "\t" * self.indent_width * depth
 
     @classmethod
-    def load(cls, config_file_path):
-        with open(config_file_path) as f:
-            kwargs = toml.load(f).get("codegen")
-            return CodeGenConfig(**kwargs)
+    def load(cls, fp: TextIO):
+        kwargs = toml.load(fp).get("codegen")
+        return CodeGenConfig(**kwargs)

atcodertools/tools/envgen.py

@@ -216,7 +216,8 @@ def check_lang(lang: str):
 def get_code_gen_config(config_path: Optional[str] = None):
     def _load(path: str):
         logging.info("Going to load {} as config".format(path))
-        return CodeGenConfig.load(path)
+        with open(path, 'r') as f:
+            return CodeGenConfig.load(f)
 
     if config_path:
         return _load(config_path)

tests/test_codegen.py

@@ -83,14 +83,17 @@ def get_generator(self, lang: str) -> CodeGenerator:
             return self.lang_to_code_generator[lang](f.read())
 
     def test_load_code_gen_config(self):
-        toml_path = os.path.join(RESOURCE_DIR, "atcodertools-test.toml")
-        config = CodeGenConfig.load(toml_path)
+        with open(os.path.join(RESOURCE_DIR, "atcodertools-test.toml"), 'r') as f:
+            config = CodeGenConfig.load(f)
+
         self.assertEqual(8, config.indent_width)
         self.assertEqual(INDENT_TYPE_SPACE, config.indent_type)
 
     def test_init_code_gen_config_with_invalid_parameters(self):
-        self._expect_error_when_init_config(indent_type='SPACE', indent_width=4)
-        self._expect_error_when_init_config(indent_type='space', indent_width=-1)
+        self._expect_error_when_init_config(
+            indent_type='SPACE', indent_width=4)
+        self._expect_error_when_init_config(
+            indent_type='space', indent_width=-1)
 
     def _expect_error_when_init_config(self, **kwargs):
         try: