Commit 8ebf968
Dummy (#114)
* Compute stepDummyUnfinalizedProof via expand_deferred
Replace ad-hoc tick-derived placeholder values with a full PureScript
implementation of OCaml's Wrap_deferred_values.expand_deferred applied
to proof.ml:dummy. All deferred values (xi, perm, zetaToSrsLength,
zetaToDomainSize, combinedInnerProduct, b, ftEval0) are now computed
from first principles using existing building blocks:
- frSpongeChallengesPure for xi/evalscale (sponge transcript)
- permScalar for perm (permutation argument)
- ftEval0 from permContribution + gateConstraints
- CIP via Horner fold with sg evals from bPoly
- computeB for challenge polynomial evaluation
Key discoveries during implementation:
- Backend.Tick = Vesta_based_plonk (not Pallas), so
srs_length_log2 = StepIPARounds = 16, not WrapIPARounds = 15
- OCaml Vector.map (list-based ::) evaluates side effects
right-to-left, requiring reversed tick generation for prev_evals
- zkPolynomial uses permutationVanishingPolynomial, not
vanishesOnZkAndPreviousRows (which is F.one without lookups)
Also: make stepDummyUnfinalizedProof polymorphic over shifted type
(Type1/Type2) so it works for both constant-level and circuit-level
usage. Replace all genDummyUnfinalizedProof random generators with
the production library value.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Replace random dummy generators with production library values
Move dummyStepAdvice from TestContext (random Gen) to Pickles.Dummy
(deterministic, matching OCaml's proof.ml:dummy):
- Messages: Pallas generator for all commitment points
- Opening proof: generator for delta/sg/lr, Ro.tock() for z1/z2
- FOP proof state: stepDummyUnfinalizedProof (expand_deferred)
Remove genDummyUnfinalizedProof and dummyStepAdvice random generators
from TestContext. All test files now use library values exclusively.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Clean up unused imports from dummy generator removal
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* move some commitments to params
* Address review feedback: bounds guard, strict fixtures, clean comments
- P0: Add SRS bounds check in pallas/vesta_srs_b_poly_commitment to
return an error instead of panicking on out-of-bounds slice
- P1: assertField now throws on missing fixture keys instead of
silently passing, preventing typos from hiding regressions
- P2: Replace contradictory self-correcting tock counter comments
with a single clean count matching the actual code
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* add exhaustiveness checl
* cargo fmt
* Capture tock evals, compute wrap perm, add fixture exhaustiveness check
- Replace discarded Phase 3 tock calls with wrapDummyEvals :: AllEvals
WrapField in roComputeResult, using the same right-to-left eval order
- Compute wrapDummyUnfinalizedProof.perm via permScalar on wrapDummyEvals
instead of hardcoding from OCaml fixture — validates tock eval ordering
- Share computed perm with computeDummySgValues (remove last hardcoded string)
- Add "every fixture output key is checked" exhaustiveness test
- assertField tracks checked keys via Ref; input-only keys (prev_evals.*,
step_input.*) are exempt since they're verified indirectly through outputs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Use Shifted typeclass for Type2, compute wrap perm, add exhaustiveness check
- Capture Phase 3 tock evals as wrapDummyEvals in roComputeResult
(same right-to-left eval order as Step prev_evals)
- Compute wrapDummyUnfinalizedProof.perm via permScalar on wrapDummyEvals
instead of hardcoding — validates tock eval ordering matches OCaml
- Replace manual Type2 shifting (type2Shift, shifted helper) with the
existing Shifted (F f) (Type2 (F f)) typeclass instance
- Add fixture exhaustiveness test ensuring every output key is asserted
- Remove tockEvalPair, type2Shift, fromStr helpers
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 8ba27e4 commit 8ebf968
File tree
22 files changed
+1364
-468
lines changed- packages
- crypto-provider/src/kimchi
- pickles-circuit-diffs
- src/Pickles/CircuitDiffs/PureScript
- test
- Test
- Pickles/CircuitDiffs
- fixtures
- pickles
- src/Pickles
- Step
- Wrap
- test/Test/Pickles
- Step
- Wrap
- snarky-kimchi/src/Snarky/Backend/Kimchi/Impl
22 files changed
+1364
-468
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2677 | 2677 | | |
2678 | 2678 | | |
2679 | 2679 | | |
| 2680 | + | |
| 2681 | + | |
| 2682 | + | |
| 2683 | + | |
| 2684 | + | |
| 2685 | + | |
| 2686 | + | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
| 2693 | + | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
| 2697 | + | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
| 2701 | + | |
| 2702 | + | |
| 2703 | + | |
| 2704 | + | |
| 2705 | + | |
| 2706 | + | |
| 2707 | + | |
| 2708 | + | |
| 2709 | + | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
| 2716 | + | |
| 2717 | + | |
| 2718 | + | |
| 2719 | + | |
| 2720 | + | |
| 2721 | + | |
| 2722 | + | |
| 2723 | + | |
| 2724 | + | |
| 2725 | + | |
| 2726 | + | |
| 2727 | + | |
| 2728 | + | |
| 2729 | + | |
| 2730 | + | |
| 2731 | + | |
| 2732 | + | |
| 2733 | + | |
| 2734 | + | |
| 2735 | + | |
| 2736 | + | |
| 2737 | + | |
| 2738 | + | |
| 2739 | + | |
| 2740 | + | |
| 2741 | + | |
Lines changed: 10 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | 154 | | |
160 | 155 | | |
161 | 156 | | |
162 | 157 | | |
163 | 158 | | |
164 | 159 | | |
165 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
Lines changed: 10 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
145 | 147 | | |
146 | 148 | | |
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | 152 | | |
158 | 153 | | |
159 | 154 | | |
160 | 155 | | |
161 | 156 | | |
162 | 157 | | |
163 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
| |||
Lines changed: 212 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
444 | 445 | | |
445 | 446 | | |
446 | 447 | | |
| 448 | + | |
0 commit comments