Skip to content

Commit 02accdf

Browse files
siliconrecyclegregkh
authored andcommitted
staging: sm750fb: remove unnecessary volatile qualifiers
The use of 'volatile' for memory-mapped I/O pointers is discouraged in the Linux kernel as per Documentation/process/volatile-considered-harmful.rst. This patch removes the unnecessary 'volatile' qualifiers from the lynx_accel struct members, improving code quality and maintainability. Signed-off-by: Yiming Qian <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6f19c1e commit 02accdf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/staging/sm750fb/sm750.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ struct init_status {
5050

5151
struct lynx_accel {
5252
/* base virtual address of DPR registers */
53-
volatile unsigned char __iomem *dprBase;
53+
unsigned char __iomem *dprBase;
5454
/* base virtual address of de data port */
55-
volatile unsigned char __iomem *dpPortBase;
55+
unsigned char __iomem *dpPortBase;
5656

5757
/* function pointers */
5858
void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor {
128128
char __iomem *vstart;
129129
int offset;
130130
/* mmio addr of hw cursor */
131-
volatile char __iomem *mmio;
131+
char __iomem *mmio;
132132
};
133133

134134
struct lynxfb_crtc {

0 commit comments

Comments
 (0)