Skip to content

Commit 09390ed

Browse files
barni2000andersson
authored andcommitted
rpmsg: qcom_smd: Fix fallback to qcom,ipc parse
mbox_request_channel() returning value was changed in case of error. It uses returning value of of_parse_phandle_with_args(). It is returning with -ENOENT instead of -ENODEV when no mboxes property exists. Fixes: 24fdd50 ("mailbox: use error ret code of of_parse_phandle_with_args()") Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Stephan Gerhold <[email protected]> Tested-by: Stephan Gerhold <[email protected]> # msm8939 Signed-off-by: Barnabás Czémán <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent c8a8df4 commit 09390ed

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/rpmsg/qcom_smd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@ static int qcom_smd_parse_edge(struct device *dev,
13681368
edge->mbox_client.knows_txdone = true;
13691369
edge->mbox_chan = mbox_request_channel(&edge->mbox_client, 0);
13701370
if (IS_ERR(edge->mbox_chan)) {
1371-
if (PTR_ERR(edge->mbox_chan) != -ENODEV) {
1371+
if (PTR_ERR(edge->mbox_chan) != -ENOENT) {
13721372
ret = dev_err_probe(dev, PTR_ERR(edge->mbox_chan),
13731373
"failed to acquire IPC mailbox\n");
13741374
goto put_node;

0 commit comments

Comments
 (0)