HID: intel-thc-hid: intel-thc: Fix error code in thc_i2c_subip_init()

Dan Carpenter · Benjamin Tissoires · commit 0b0d62fa73f2 · 2025-01-13T10:47:12.000+01:00
Return -ENOMEM if the allocation fails. Don't return success. Fixes: 4228966 ("HID: intel-thc-hid: intel-thc: Add THC I2C config interfaces") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/eb4ea363-c3b7-4988-9ff5-5ed74bf47620@stanley.mountain Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
@@ -1519,7 +1519,7 @@ int thc_i2c_subip_init(struct thc_device *dev, const u32 target_address,
 
 	dev->i2c_subip_regs = devm_kzalloc(dev->dev, sizeof(i2c_subip_regs), GFP_KERNEL);
 	if (!dev->i2c_subip_regs)
-		return PTR_ERR(dev->i2c_subip_regs);
+		return -ENOMEM;
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1519,7 +1519,7 @@ int thc_i2c_subip_init(struct thc_device *dev, const u32 target_address,`
`1519`	`1519`
`1520`	`1520`	`dev->i2c_subip_regs = devm_kzalloc(dev->dev, sizeof(i2c_subip_regs), GFP_KERNEL);`
`1521`	`1521`	`if (!dev->i2c_subip_regs)`
`1522`		`- return PTR_ERR(dev->i2c_subip_regs);`
	`1522`	`+ return -ENOMEM;`
`1523`	`1523`
`1524`	`1524`	`return 0;`
`1525`	`1525`	`}`