Skip to content

Commit 2d51d04

Browse files
committed
fix: address PR review feedback
- Remove no-op expect(true).toBe(true) assertion in catch block - Fix Android emulator name mismatch (Pixel_9_Pro -> test) to match CI AVD
1 parent ef4d518 commit 2d51d04

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

example/showcase/rn-harness.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const config = {
2020
}),
2121
androidPlatform({
2222
name: 'android',
23-
device: androidEmulator('Pixel_9_Pro'),
23+
device: androidEmulator('test'),
2424
bundleId: 'nitrodeviceinfo.example',
2525
}),
2626
],

example/showcase/src/__tests__/platform-specific.harness.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ describe('Android-Specific APIs', () => {
6767
const hasGms = DeviceInfoModule.getHasGms();
6868
expect(typeof hasGms).toBe('boolean');
6969
} catch {
70-
// NoClassDefFoundError is expected on emulators without Google Play Services
71-
expect(true).toBe(true);
70+
// NoClassDefFoundError is expected on emulators without Google Play Services.
71+
// Test passes if no unexpected error propagates.
7272
}
7373
}
7474
});

0 commit comments

Comments
 (0)