Skip to content

Commit aef8e8c

Browse files
authored
ci: fix wrong path of showcase example (#1)
* ci: fix wrong path of showcase example * fix: xcode version * fix: permit reuse ci script * fix: android showcase app build * Revert "fix: android showcase app build" This reverts commit d1a153d. * fix: reduce scope of assembleDebug
1 parent ae56ff8 commit aef8e8c

File tree

1 file changed

+9
-40
lines changed

1 file changed

+9
-40
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
branches: [main, develop]
66
pull_request:
77
branches: [main, develop]
8+
workflow_call:
89

910
jobs:
1011
lint:
@@ -29,32 +30,6 @@ jobs:
2930
- name: Run TypeScript type check
3031
run: yarn typecheck
3132

32-
test:
33-
name: Test
34-
runs-on: ubuntu-latest
35-
steps:
36-
- name: Checkout
37-
uses: actions/checkout@v4
38-
39-
- name: Setup Node.js
40-
uses: actions/setup-node@v4
41-
with:
42-
node-version: '20'
43-
cache: 'yarn'
44-
45-
- name: Install dependencies
46-
run: yarn install --frozen-lockfile
47-
48-
- name: Run tests
49-
run: yarn test --coverage
50-
51-
- name: Upload coverage
52-
uses: codecov/codecov-action@v4
53-
with:
54-
files: ./coverage/lcov.info
55-
flags: unittests
56-
name: codecov-umbrella
57-
5833
build:
5934
name: Build Library
6035
runs-on: ubuntu-latest
@@ -82,7 +57,7 @@ jobs:
8257
8358
build-ios:
8459
name: Build iOS
85-
runs-on: macos-14
60+
runs-on: macos-15
8661
steps:
8762
- name: Checkout
8863
uses: actions/checkout@v4
@@ -100,15 +75,15 @@ jobs:
10075
run: yarn prepare
10176

10277
- name: Install example dependencies
103-
working-directory: example
78+
working-directory: example/showcase
10479
run: yarn install --frozen-lockfile
10580

10681
- name: Install Pods
107-
working-directory: example/ios
82+
working-directory: example/showcase/ios
10883
run: pod install
10984

11085
- name: Build iOS app
111-
working-directory: example
86+
working-directory: example/showcase
11287
run: |
11388
xcodebuild \
11489
-workspace ios/NitroDeviceInfoExample.xcworkspace \
@@ -145,22 +120,16 @@ jobs:
145120
run: yarn prepare
146121

147122
- name: Install example dependencies
148-
working-directory: example
123+
working-directory: example/showcase
149124
run: yarn install --frozen-lockfile
150125

151126
- name: Run ktlint checks
152-
working-directory: example/android
127+
working-directory: example/showcase/android
153128
run: ./gradlew :react-native-nitro-device-info:ktlintCheck --no-daemon
154129

155130
- name: Build Android app
156-
working-directory: example/android
157-
run: ./gradlew assembleRelease --no-daemon
158-
159-
- name: Upload APK
160-
uses: actions/upload-artifact@v4
161-
with:
162-
name: app-release.apk
163-
path: example/android/app/build/outputs/apk/release/app-release.apk
131+
working-directory: example/showcase/android
132+
run: ./gradlew :app:assembleDebug --no-daemon
164133

165134
validate-package:
166135
name: Validate NPM Package

0 commit comments

Comments
 (0)