Skip to content

Commit e3b4a6a

Browse files
committed
fix(ci): use correct build commands for iOS and Android
iOS: - Use xcodebuild directly instead of 'react-native build-ios --simulator' which doesn't exist - Build for iphonesimulator SDK with Debug configuration Android: - Separate 'Build Android App' step using './gradlew assembleDebug' - This generates APK at the expected path for adb install - Previous 'react-native build-android' was creating AAB bundle instead
1 parent f936c19 commit e3b4a6a

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,14 @@ jobs:
6666
6767
- name: Build iOS App
6868
working-directory: example/showcase
69-
run: npx react-native build-ios --mode=Debug --simulator
69+
run: |
70+
xcodebuild -workspace ios/NitroDeviceInfoExample.xcworkspace \
71+
-scheme NitroDeviceInfoExample \
72+
-configuration Debug \
73+
-sdk iphonesimulator \
74+
-destination "id=$SIMULATOR_DEVICE_ID" \
75+
-derivedDataPath ios/build \
76+
build
7077
7178
- name: Install iOS App
7279
run: |
@@ -146,6 +153,10 @@ jobs:
146153
working-directory: example/showcase
147154
run: yarn install --immutable
148155

156+
- name: Build Android App
157+
working-directory: example/showcase/android
158+
run: ./gradlew assembleDebug
159+
149160
- name: Create AVD and run E2E tests
150161
uses: reactivecircus/android-emulator-runner@v2
151162
with:
@@ -157,8 +168,7 @@ jobs:
157168
disable-animations: true
158169
working-directory: example/showcase
159170
script: |
160-
# Build and install the Android app
161-
npx react-native build-android --mode=debug
171+
# Install the Android app
162172
adb install android/app/build/outputs/apk/debug/app-debug.apk
163173
# Run E2E tests
164174
npx react-native-harness --harnessRunner android

0 commit comments

Comments
 (0)