Skip to content

Commit 8e70dd9

Browse files
committed
- Fix include paths for nlohmann/json in minja headers
- removed performance logging for android
1 parent f0ef931 commit 8e70dd9

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

ggml/src/ggml-vulkan/ggml-vulkan.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9506,7 +9506,9 @@ static ggml_status ggml_backend_vk_graph_compute(ggml_backend_t backend, ggml_cg
95069506
bool first_node_in_batch = true; // true if next node will be first node in a batch
95079507
int submit_node_idx = 0; // index to first node in a batch
95089508

9509-
vk_context compute_ctx;
9509+
// Android does not link with Vulkan 1.1 libraries, so we do not have access to the "resetQueryPool", so we disable perf logger completely
9510+
vk_context compute_ctx; // note we keep the compute_ctx declaration here; if we make sure "vk_perf_logger_enabled" is always false, this will have no effect
9511+
#ifndef ANDROID
95109512
if (vk_perf_logger_enabled) {
95119513
// allocate/resize the query pool
95129514
if (ctx->device->num_queries < cgraph->n_nodes + 1) {
@@ -9528,6 +9530,7 @@ static ggml_status ggml_backend_vk_graph_compute(ggml_backend_t backend, ggml_cg
95289530
ggml_vk_ctx_begin(ctx->device, compute_ctx);
95299531
compute_ctx->s->buffer.writeTimestamp(vk::PipelineStageFlagBits::eAllCommands, ctx->device->query_pool, 0);
95309532
}
9533+
#endif
95319534

95329535
// Submit after enough work has accumulated, to overlap CPU cmdbuffer generation with GPU execution.
95339536
// Estimate the amount of matmul work by looking at the weight matrix size, and submit every 100MB

vendor/minja/chat-template.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <stdexcept>
2121
#include <string>
2222
#include <vector>
23-
#include <json.hpp>
23+
#include "nlohmann/json.hpp"
2424

2525
using json = nlohmann::ordered_json;
2626

vendor/minja/minja.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include <unordered_set>
2929
#include <utility>
3030
#include <vector>
31-
#include <json.hpp>
31+
#include "nlohmann/json.hpp"
3232

3333
using json = nlohmann::ordered_json;
3434

0 commit comments

Comments
 (0)