fix: Prevent random restarts by declaring the metrics port in the pod manifest

Author: rg0now

internal/renderer/dataplane_util.go

@@ -228,13 +228,11 @@ func generateDataplanePodSpec(c *RenderContext, dataplane *stnrgwv1.Dataplane) (
 			c.SecurityContext = dataplane.Spec.ContainerSecurityContext.DeepCopy()
 		}
 
-		if dataplane.Spec.EnableMetricsEnpoint {
-			c.Ports = []corev1.ContainerPort{{
-				Name:          opdefault.DefaultMetricsPortName,
-				ContainerPort: int32(stnrconfv1.DefaultMetricsPort),
-				Protocol:      corev1.ProtocolTCP,
-			}}
-		}
+		c.Ports = []corev1.ContainerPort{{
+			Name:          opdefault.DefaultMetricsPortName,
+			ContainerPort: int32(stnrconfv1.DefaultMetricsPort),
+			Protocol:      corev1.ProtocolTCP,
+		}}
 
 		found = true
 	}

test/managed_mode_test.go

@@ -1172,7 +1172,8 @@ func testManagedMode() {
 			// Expect(container.VolumeMounts).To(HaveLen(1))
 
 			Expect(container.ImagePullPolicy).Should(Equal(corev1.PullAlways))
-			Expect(container.Ports).To(HaveLen(0))
+			// we always declare the metrics port, even if the metrics server is diabled
+			Expect(container.Ports).To(HaveLen(1))
 
 			// remainder
 			Expect(podSpec.TerminationGracePeriodSeconds).NotTo(BeNil())