fix getByKey with expand when resource not found

Author: mikedebock

src/services/product-projection.test.ts

@@ -56,6 +56,17 @@ describe('Product Projection', () => {
     })
   })
 
+  test('Get product projection by 404 when not found by key with expand', async () => {
+    const response = await supertest(ctMock.app).get(
+      '/dummy/product-projections/key=DOESNOTEXIST?' +
+        qs.stringify({
+          expand: ['categories[*]'],
+        })
+    )
+
+    expect(response.status).toBe(404)
+  })
+
   test('Search product projection', async () => {
     ctMock.project('dummy').add('product-projection', {
       id: '',

src/storage.ts

@@ -211,8 +211,14 @@ export class InMemoryStorage extends AbstractStorage {
 
     const resources: any[] = Array.from(store.values())
     const resource = resources.find(e => e.key === key)
-    if (params.expand) return this.expand(projectKey, resource, params.expand)
-    return resource
+    if (resource) {
+      return this.expand(
+        projectKey,
+        resource,
+        params.expand
+      ) as ResourceMap[RepositoryTypes]
+    }
+    return null
   }
 
   delete(