Considering the numberOfErrorsAllowed setting #86
JaapvanEkris
started this conversation in
Ideas
Replies: 1 comment
-
I have removed the setting in the branch that will become V1Beta, as it isn't used anymore. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi All,
I discovered that the numberOfErrorsAllowed setting was only used in one instance: the detection of the flywheel is dwelling (i.e. moving so slow that the rower probably has stopped). However, by default, this test is performed 6 seconds after the last drive, thus the flywheel is in a spindown for about 5 seconds (assuming a drive takes about 1 second max). Although most flywheels can take minutes to come to a full stop, I think this slack might be a bit too cautious (and confusing for most new users).
Should we remove the numberOfErrorsAllowed alltogether in V1Beta?
Beta Was this translation helpful? Give feedback.
All reactions