Skip to content

Commit 6daf4a6

Browse files
committed
[CUB-5407] address feedback
1 parent ae897a8 commit 6daf4a6

File tree

7 files changed

+25
-18
lines changed

7 files changed

+25
-18
lines changed

dist/index.d.ts

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/workflow-step-template-schema.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/workflow-template-schema.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/schemata/definitions/step/command-handler.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ title: Command Handler
44
description: |
55
A Command handler always consists of an [action](/schemas/definitions/workflow-template/actions/).
66
required: [do]
7+
additionalProperties: false
78
properties:
89
do:
910
$ref: '#/definitions/workflow-template/actions'

src/schemata/definitions/workflow-template/action-objects/send-command.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ additionalProperties:
2525
The command to execute. Available commands are device
2626
specific.
2727
onSuccess:
28-
description: The handler for response status codes 2xx
28+
description: The handler for success response
2929
$ref: '#/definitions/step/command-handler'
3030
onError:
31-
description: The handler for response status codes 5xx
31+
description: The handler for error response
3232
$ref: '#/definitions/step/command-handler'

src/workflow-step-template-schema.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,14 +1621,14 @@
16211621
"markdownDescription": "The command to execute. Available commands are device\nspecific.\n\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
16221622
},
16231623
"onSuccess": {
1624-
"description": "The handler for response status codes 2xx",
1624+
"description": "The handler for success response",
16251625
"$ref": "#/definitions/step/command-handler",
1626-
"markdownDescription": "The handler for response status codes 2xx\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
1626+
"markdownDescription": "The handler for success response\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
16271627
},
16281628
"onError": {
1629-
"description": "The handler for response status codes 5xx",
1629+
"description": "The handler for error response",
16301630
"$ref": "#/definitions/step/command-handler",
1631-
"markdownDescription": "The handler for response status codes 5xx\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
1631+
"markdownDescription": "The handler for error response\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
16321632
}
16331633
}
16341634
},
@@ -3257,6 +3257,7 @@
32573257
"required": [
32583258
"do"
32593259
],
3260+
"additionalProperties": false,
32603261
"properties": {
32613262
"do": {
32623263
"$ref": "#/definitions/workflow-template/actions"

src/workflow-template-schema.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,6 +1447,7 @@
14471447
"required": [
14481448
"do"
14491449
],
1450+
"additionalProperties": false,
14501451
"properties": {
14511452
"do": {
14521453
"$ref": "#/definitions/workflow-template/actions"
@@ -2766,14 +2767,14 @@
27662767
"markdownDescription": "The command to execute. Available commands are device\nspecific.\n\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
27672768
},
27682769
"onSuccess": {
2769-
"description": "The handler for response status codes 2xx",
2770+
"description": "The handler for success response",
27702771
"$ref": "#/definitions/step/command-handler",
2771-
"markdownDescription": "The handler for response status codes 2xx\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
2772+
"markdownDescription": "The handler for success response\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
27722773
},
27732774
"onError": {
2774-
"description": "The handler for response status codes 5xx",
2775+
"description": "The handler for error response",
27752776
"$ref": "#/definitions/step/command-handler",
2776-
"markdownDescription": "The handler for response status codes 5xx\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
2777+
"markdownDescription": "The handler for error response\n\nSee more: [Send Command Schema](https://schema.laboperator.com/schemas/definitions/workflow-template/action-objects/send-command) "
27772778
}
27782779
}
27792780
},

0 commit comments

Comments
 (0)