remote/coordinator: fail acquire for orphaned

Check if a place acquire request tries to lock a resource that is marked
as orphaned. This means we no longer need to reacquire orphaned resource
before trying to acquire a places resources since we now refuse to
acquire the resources.

This avoids long delays on aquire calls if the exporter responsible for
an (unrelated) orphaned resource doesn't process commands quickly.

Signed-off-by: Rouven Czerwinski <[email protected]>

Author: Emantor

labgrid/remote/coordinator.py

@@ -638,6 +638,14 @@ async def _acquire_resources(self, place, resources):
             if resource.acquired:
                 return False
 
+            for otherplace in self.places.values():
+                for oldres in otherplace.acquired_resources:
+                    if resource.path == oldres.path:
+                        logging.info(
+                            "Conflicting orphaned resource %s for acquire request for place %s", oldres, place.name
+                        )
+                        return False
+
         # acquire resources
         acquired = []
         try:
@@ -755,9 +763,6 @@ async def AcquirePlace(self, request, context):
             if not res.owner == username:
                 await context.abort(grpc.StatusCode.PERMISSION_DENIED, f"Place {name} was not reserved for {username}")
 
-        # First try to reacquire orphaned resources to avoid conflicts.
-        await self._reacquire_orphaned_resources()
-
         # FIXME use the session object instead? or something else which
         # survives disconnecting clients?
         place.acquired = username