Skip to content

Commit 5755430

Browse files
Merge pull request #1449 from Bastian-Krause/bst/examples-fixes
examples: fixes, cleanup, use StepLogger instead of StepReporter
2 parents 8af37ae + a3bc87c commit 5755430

File tree

13 files changed

+54
-92
lines changed

13 files changed

+54
-92
lines changed

examples/deditec-relais8/deditec.py

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,19 @@
1-
import sys
2-
import labgrid
31
import logging
42
import time
53

6-
from labgrid import Environment, StepReporter
7-
from labgrid.strategy.bareboxstrategy import Status
8-
from labgrid.driver.deditecrelaisdriver import DeditecRelaisDriver
4+
from labgrid import Target
5+
from labgrid.logging import basicConfig, StepLogger
6+
from labgrid.resource.udev import DeditecRelais8
7+
from labgrid.driver import DeditecRelaisDriver
98

10-
# enable debug logging
11-
logging.basicConfig(
12-
level=logging.DEBUG,
13-
format='%(levelname)7s: %(message)s',
14-
stream=sys.stderr,
15-
)
9+
# enable info logging
10+
basicConfig(level=logging.INFO)
1611

17-
# show labgrid steps on the console
18-
StepReporter.start()
12+
# log labgrid steps
13+
StepLogger.start()
1914

20-
t = labgrid.Target('main')
21-
r = labgrid.resource.udev.DeditecRelais8(t, name=None, index=1)
15+
t = Target('main')
16+
r = DeditecRelais8(t, name=None, index=1)
2217
d = DeditecRelaisDriver(t, name=None)
2318

2419
p = t.get_driver("DigitalOutputProtocol")

examples/deditec-relais8/deditec_remote.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
1-
import sys
2-
import labgrid
31
import logging
42
import time
53

6-
from labgrid import Environment, StepReporter
7-
from labgrid.strategy.bareboxstrategy import Status
8-
from labgrid.driver.deditecrelaisdriver import DeditecRelaisDriver
4+
from labgrid import Environment
5+
from labgrid.logging import basicConfig, StepLogger
96

10-
# enable debug logging
11-
logging.basicConfig(
12-
level=logging.DEBUG,
13-
format='%(levelname)7s: %(message)s',
14-
stream=sys.stderr,
15-
)
7+
# enable info logging
8+
basicConfig(level=logging.INFO)
169

1710
# show labgrid steps on the console
18-
StepReporter.start()
11+
StepLogger.start()
1912

20-
e = labgrid.Environment('import-dedicontrol.yaml')
13+
e = Environment('import-dedicontrol.yaml')
2114
t = e.get_target()
2215

2316
p = t.get_driver("DigitalOutputProtocol")

examples/library/test.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,16 @@
44
import sys
55
import logging
66

7-
from labgrid import Environment, StepReporter
7+
from labgrid import Environment
8+
from labgrid.logging import basicConfig, StepLogger
89
from labgrid.strategy.bareboxstrategy import Status
910

1011

11-
# enable debug logging
12-
logging.basicConfig(
13-
level=logging.DEBUG,
14-
format='%(levelname)7s: %(message)s',
15-
stream=sys.stderr,
16-
)
12+
# enable info logging
13+
basicConfig(level=logging.INFO)
1714

18-
# show labgrid steps on the console
19-
StepReporter.start()
15+
# log labgrid steps
16+
StepLogger.start()
2017

2118
def run_once(target):
2219
s = target.get_driver('BareboxStrategy')

examples/networkmanager/nm.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
1-
import logging, sys
1+
import logging
22
from pprint import pprint
33

4-
from labgrid import *
4+
from labgrid import Environment
5+
from labgrid.logging import basicConfig, StepLogger
56

67

78
# enable debug logging
8-
logging.basicConfig(
9-
level=logging.DEBUG,
10-
format='%(levelname)7s: %(message)s',
11-
stream=sys.stderr,
12-
)
9+
basicConfig(level=logging.DEBUG)
1310

1411
# show labgrid steps on the console
15-
StepReporter.start()
12+
StepLogger.start()
1613

1714

1815
e = Environment('nm.env')

examples/qemu-networking/qemunetworkstrategy.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import attr
1818

1919
from labgrid import target_factory, step
20-
from labgrid.strategy import Strategy
20+
from labgrid.strategy import Strategy, StrategyError
2121
from labgrid.util import get_free_port
2222

2323

@@ -75,15 +75,15 @@ def update_network_service(self):
7575
networkservice.port = local_port
7676
else:
7777
networkservice.address = new_address
78-
networkserivce.port = self.__remote_port
78+
networkservice.port = self.__remote_port
7979

8080
@step(args=["state"])
8181
def transition(self, state, *, step):
8282
if not isinstance(state, Status):
8383
state = Status[state]
8484

8585
if state == Status.unknown:
86-
raise StrategyError(f"can not transition to {new_status}")
86+
raise StrategyError(f"can not transition to {state}")
8787

8888
elif self.status == state:
8989
step.skip("nothing to do")
@@ -99,4 +99,4 @@ def transition(self, state, *, step):
9999
self.target.activate(self.shell)
100100
self.update_network_service()
101101

102-
self.status = status
102+
self.status = state

examples/sigrok/main.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
import logging
77

88
from labgrid import Environment
9+
from labgrid.logging import basicConfig
910

10-
# enable debug logging
11-
logging.basicConfig(
12-
level=logging.DEBUG,
13-
format='%(levelname)7s: %(message)s',
14-
stream=sys.stderr,
15-
)
11+
# enable info logging
12+
basicConfig(level=logging.INFO)
1613

1714
env = Environment(sys.argv[1])
1815
target = env.get_target('main')

examples/strategy/bareboxrebootstrategy.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22

33
import attr
44

5+
from labgrid import target_factory, step
56
from labgrid.driver import BareboxDriver, ShellDriver
67
from labgrid.protocol import PowerProtocol
7-
from labgrid.factory import target_factory
8-
from labgrid.step import step
9-
from labgrid.strategy.common import Strategy
8+
from labgrid.strategy import Strategy
109

1110

1211
@attr.s(eq=False)

examples/strategy/quartusstrategy.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22

33
import attr
44

5+
from labgrid import target_factory, step
56
from labgrid.driver import QuartusHPSDriver, SerialDriver
6-
from labgrid.factory import target_factory
77
from labgrid.protocol import PowerProtocol
8-
from labgrid.step import step
9-
from labgrid.strategy.common import Strategy
8+
from labgrid.strategy import Strategy
109

1110

1211
@attr.s(eq=False)

examples/strategy/test_barebox_strategy.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import pytest
22

3-
from labgrid.exceptions import NoDriverFoundError
4-
53

64
@pytest.fixture(scope="function")
75
def in_bootloader(strategy, capsys):

examples/sysfsgpio/sysfsgpio.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
1-
import sys
2-
import labgrid
31
import logging
42
import time
53

6-
from labgrid import Environment, StepReporter
7-
from labgrid.driver.gpiodriver import GpioDigitalOutputDriver
4+
from labgrid import Target
5+
from labgrid.logging import basicConfig, StepLogger
6+
from labgrid.driver import GpioDigitalOutputDriver
7+
from labgrid.resource import SysfsGPIO
88

9-
# enable debug logging
10-
logging.basicConfig(
11-
level=logging.DEBUG,
12-
format='%(levelname)7s: %(message)s',
13-
stream=sys.stderr,
14-
)
9+
# enable info logging
10+
basicConfig(level=logging.INFO)
1511

1612
# show labgrid steps on the console
17-
StepReporter.start()
13+
StepLogger.start()
1814

19-
t = labgrid.Target('main')
20-
r = labgrid.resource.base.SysfsGPIO(t, name=None, index=60)
15+
t = Target('main')
16+
r = SysfsGPIO(t, name=None, index=60)
2117
d = GpioDigitalOutputDriver(t, name=None)
2218

2319
p = t.get_driver("DigitalOutputProtocol")

0 commit comments

Comments
 (0)