Skip to content

Commit 82ca4ab

Browse files
driver/power/siglent: use backend function signatures expected by NetworkPowerDriver
When using the siglent power backend with the NetworkPowerDriver, this error occurs: self = NetworkPowerDriver(target=Target(name='Test', env=None), name='power', state=<BindingState.active: 2>, delay=2.0) @Driver.check_active @step() def off(self): > self.backend.power_set(self._host, self._port, self.port.index, False) E TypeError: power_set() takes 3 positional arguments but 4 were given labgrid/driver/powerdriver.py:219: TypeError The siglent backend does not follow the function signatures expected by the NetworkPowerDriver, because it's missing the port parameter. Fix that by adding the port parameter and making sure that it's None, just like other backends do (apc, rest, sentry, simplerest, tplink). Fixes: da0a81d ("driver/power: add support for Siglent SPD3000X series power supplies") Signed-off-by: Bastian Krause <[email protected]>
1 parent dffc61d commit 82ca4ab

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

labgrid/driver/power/siglent.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,17 @@
33
import vxi11
44

55

6-
def power_set(host, index, value):
6+
def power_set(host, port, index, value):
7+
assert port is None
78
index = int(index)
89
assert 1 <= index <= 2
910
value = "ON" if value else "OFF"
1011
psu = vxi11.Instrument(host)
1112
psu.write(f"OUTPUT CH{index},{value}")
1213

1314

14-
def power_get(host, index):
15+
def power_get(host, port, index):
16+
assert port is None
1517
index = int(index)
1618
assert 1 <= index <= 2
1719
psu = vxi11.Instrument(host)

0 commit comments

Comments
 (0)