Nfs provider export #1657
Open
Nfs provider export #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFSProvider does no longer inherit from `BaseProvider` as of labgrid-project#1249 and, as such, does not have the corresponding `internal` and `external` parameters anymore. This leads to an error with `ProviderGenericExport` which expects these parameters (as it is meant for subclasses of `BaseProvider`). Signed-off-by: jrichardsen <[email protected]>
Add `NFSProviderExport` for exporting `NFSProvider` to `RemoteNFSProvider`. Signed-off-by: jrichardsen <[email protected]>
Signed-off-by: jrichardsen <[email protected]>
|
The tests introduced here succeed even without the other changes. Why is that? |
Bastian-Krause
added
the
needs author info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #1249, the
NFSProviderno longer inherits fromBaseProviderand no longer has theinternalandexternalproperties. This leads to an error withProviderGenericExportwhich is meant for subclasses ofBaseProviderand, thus, expects these properties to be present.This PR removes
NFSProviderfrom theProviderGenericExportand implements a newNFSProviderExportinstead.Checklist