refactor(BA-4092): Simplify repository test fixtures

- Merge purgable/non_purgable fixtures into single vfolder_in_db
- Use indirect parametrization to pass status to fixture
- Return only vfolder_id from fixture (status not needed)

Author: fregataa

tests/unit/manager/repositories/vfolder/test_vfolder_repository.py

@@ -626,41 +626,51 @@ async def _vfolder_exists(self, db: ExtendedAsyncSAEngine, vfolder_id: uuid.UUID
             result = await session.execute(query)
             return result.scalar_one_or_none() is not None
 
+    @pytest.fixture
+    async def vfolder_in_db(
+        self,
+        request: pytest.FixtureRequest,
+        db_with_cleanup: ExtendedAsyncSAEngine,
+        test_domain_name: str,
+        test_user: uuid.UUID,
+    ) -> uuid.UUID:
+        """Create a vfolder with the given status in DB."""
+        status: VFolderOperationStatus = request.param
+        vfolder_id = uuid.uuid4()
+        await self._create_vfolder_in_db(
+            db_with_cleanup,
+            vfolder_id=vfolder_id,
+            domain_name=test_domain_name,
+            user_id=test_user,
+            status=status,
+        )
+        return vfolder_id
+
     @pytest.mark.parametrize(
-        "status",
+        "vfolder_in_db",
         [
             VFolderOperationStatus.DELETE_COMPLETE,
             VFolderOperationStatus.DELETE_PENDING,
         ],
         ids=["delete_complete", "delete_pending"],
+        indirect=True,
     )
     async def test_purge_vfolder_success(
         self,
         db_with_cleanup: ExtendedAsyncSAEngine,
         vfolder_repository: VfolderRepository,
-        test_domain_name: str,
-        test_user: uuid.UUID,
-        status: VFolderOperationStatus,
+        vfolder_in_db: uuid.UUID,
     ) -> None:
         """Test successful purge of vfolder with purgable status."""
-        vfolder_id = uuid.uuid4()
-        await self._create_vfolder_in_db(
-            db_with_cleanup,
-            vfolder_id=vfolder_id,
-            domain_name=test_domain_name,
-            user_id=test_user,
-            status=status,
-        )
+        vfolder_id = vfolder_in_db
 
         # Verify vfolder exists before purge
         assert await self._vfolder_exists(db_with_cleanup, vfolder_id)
 
         purger = Purger(row_class=VFolderRow, pk_value=vfolder_id)
         result = await vfolder_repository.purge_vfolder(purger)
 
-        # Verify result contains correct data
         assert result.id == vfolder_id
-        assert result.status == status
 
         # Verify vfolder is deleted from DB
         assert not await self._vfolder_exists(db_with_cleanup, vfolder_id)
@@ -677,7 +687,7 @@ async def test_purge_vfolder_not_found(
             await vfolder_repository.purge_vfolder(purger)
 
     @pytest.mark.parametrize(
-        "status",
+        "vfolder_in_db",
         [
             VFolderOperationStatus.READY,
             VFolderOperationStatus.PERFORMING,
@@ -687,24 +697,16 @@ async def test_purge_vfolder_not_found(
             VFolderOperationStatus.DELETE_ERROR,
         ],
         ids=["ready", "performing", "cloning", "mounted", "delete_ongoing", "delete_error"],
+        indirect=True,
     )
     async def test_purge_vfolder_invalid_status(
         self,
         db_with_cleanup: ExtendedAsyncSAEngine,
         vfolder_repository: VfolderRepository,
-        test_domain_name: str,
-        test_user: uuid.UUID,
-        status: VFolderOperationStatus,
+        vfolder_in_db: uuid.UUID,
     ) -> None:
         """Test purge fails when vfolder has non-purgable status."""
-        vfolder_id = uuid.uuid4()
-        await self._create_vfolder_in_db(
-            db_with_cleanup,
-            vfolder_id=vfolder_id,
-            domain_name=test_domain_name,
-            user_id=test_user,
-            status=status,
-        )
+        vfolder_id = vfolder_in_db
 
         purger = Purger(row_class=VFolderRow, pk_value=vfolder_id)