Skip to content

Commit 6d5e536

Browse files
seedspiritclaude
andauthored
fix(BA-4108): Use model_validate for health check info to apply Pydantic defaults (#8389)
Co-authored-by: Claude Opus 4.5 <[email protected]>
1 parent dcbeab7 commit 6d5e536

File tree

3 files changed

+392
-11
lines changed

3 files changed

+392
-11
lines changed

changes/8389.fix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Use `model_validate` for health check info to apply Pydantic defaults, preventing pydantic validation error when `initial_delay` field is missing from the YAML

src/ai/backend/manager/registry.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2404,14 +2404,7 @@ async def get_health_check_info(
24042404

24052405
for model_info in model_definition["models"]:
24062406
if health_check_info := model_info.get("service", {}).get("health_check"):
2407-
_info = ModelHealthCheck(
2408-
path=health_check_info["path"],
2409-
interval=health_check_info["interval"],
2410-
max_retries=health_check_info["max_retries"],
2411-
max_wait_time=health_check_info["max_wait_time"],
2412-
expected_status_code=health_check_info["expected_status_code"],
2413-
initial_delay=health_check_info.get("initial_delay"),
2414-
)
2407+
_info = ModelHealthCheck.model_validate(health_check_info)
24152408
break
24162409
elif (
24172410
self.config_provider.config.deployment.enable_model_definition_override

0 commit comments

Comments
 (0)