about create_snapshot and compact order

[yufan022]

raftify/raftify/src/raft_node/mod.rs

Lines 655 to 664 in ddb6b99

	pub async fn make_snapshot(&mut self, index: u64, term: u64) -> Result<()> {
	self.last_snapshot_created = Instant::now();
	let snapshot_data = self.fsm.snapshot().await?;
	let last_applied = self.raw_node.raft.raft_log.applied;
	let store = self.raw_node.mut_store();
	store.compact(last_applied)?;
	store.create_snapshot(snapshot_data, index, term)?;
	Ok(())
	}

Hi @jopemachine , i'm reading the code about snapshot, and have a question.

In my understanding, compact should be executed after saving the snapshot. Only when the snapshot is successfully saved can the expired logs be cleaned up.

If the compact operation was executed but the create_snapshot failed, would there be a problem? Would it be better if their order was switched?