Skip to content

Commit 7cc617b

Browse files
committed
Squashed commit of the following:
commit 0b698cea7230e63913dc174f7d290b2251241bad Author: David Meyer <[email protected]> Date: Fri Feb 9 10:22:53 2024 -0500 Merge pull request #64 from dihm/update_release_workflow Version bump gh actions to update node.js to 20 commit 332228533d61b80613748dbaab8a1e3a0d109e72 Author: David Meyer <[email protected]> Date: Fri Feb 9 08:02:55 2024 -0500 Merge pull request #61 from carterturn/carterturn-dropdown-cleaning Remove shot from "select markers" drop down when shot is removed commit 5dd5c5dd943b0acecac624709b6b79a0b42409b0 Author: David Meyer <[email protected]> Date: Fri Feb 9 07:45:40 2024 -0500 Merge pull request #63 from dihm/setuptools_scm_fix Ensure `release-branch-semver` is used.
1 parent 2504b18 commit 7cc617b

File tree

5 files changed

+19
-14
lines changed

5 files changed

+19
-14
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
if: github.repository == 'labscript-suite/runviewer' && (github.event_name != 'create' || github.event.ref_type != 'branch')
6565
steps:
6666
- name: Checkout
67-
uses: actions/checkout@v3
67+
uses: actions/checkout@v4
6868
with:
6969
fetch-depth: 0
7070

@@ -73,7 +73,7 @@ jobs:
7373
run: git tag -d $(git tag --points-at HEAD)
7474

7575
- name: Install Python
76-
uses: actions/setup-python@v4
76+
uses: actions/setup-python@v5
7777
with:
7878
python-version: ${{ matrix.python }}
7979
architecture: ${{ matrix.arch }}
@@ -93,7 +93,7 @@ jobs:
9393
9494
- name: Upload Artifact
9595
if: strategy.job-index == 0 || (env.PURE == 'false' && runner.os != 'Linux')
96-
uses: actions/upload-artifact@v3
96+
uses: actions/upload-artifact@v4
9797
with:
9898
name: dist
9999
path: ./dist
@@ -111,7 +111,7 @@ jobs:
111111
112112
- name: Install Miniconda
113113
if: matrix.conda
114-
uses: conda-incubator/setup-miniconda@v2
114+
uses: conda-incubator/setup-miniconda@v3
115115
with:
116116
auto-update-conda: true
117117
python-version: ${{ matrix.python }}
@@ -140,7 +140,7 @@ jobs:
140140
141141
- name: Upload Artifact
142142
if: matrix.conda
143-
uses: actions/upload-artifact@v3
143+
uses: actions/upload-artifact@v4
144144
with:
145145
name: conda_packages
146146
path: ./conda_packages
@@ -153,7 +153,7 @@ jobs:
153153
steps:
154154
- name: Checkout
155155
if: env.PURE == 'false'
156-
uses: actions/checkout@v3
156+
uses: actions/checkout@v4
157157
with:
158158
fetch-depth: 0
159159

@@ -170,7 +170,7 @@ jobs:
170170

171171
- name: Upload Artifact
172172
if: env.PURE == 'false'
173-
uses: actions/upload-artifact@v3
173+
uses: actions/upload-artifact@v4
174174
with:
175175
name: dist
176176
path: dist/*manylinux*.whl
@@ -182,13 +182,13 @@ jobs:
182182
steps:
183183

184184
- name: Download Artifact
185-
uses: actions/download-artifact@v3
185+
uses: actions/download-artifact@v4
186186
with:
187187
name: dist
188188
path: ./dist
189189

190190
- name: Download Artifact
191-
uses: actions/download-artifact@v3
191+
uses: actions/download-artifact@v4
192192
with:
193193
name: conda_packages
194194
path: ./conda_packages
@@ -226,7 +226,7 @@ jobs:
226226
password: ${{ secrets.pypi }}
227227

228228
- name: Install Miniconda
229-
uses: conda-incubator/setup-miniconda@v2
229+
uses: conda-incubator/setup-miniconda@v3
230230
with:
231231
auto-update-conda: true
232232

pyproject.toml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
[build-system]
2-
requires = ["setuptools", "wheel", "setuptools_scm", "cython"]
3-
build-backend = "setuptools.build_meta"
2+
requires = ["setuptools>=64", "wheel", "setuptools_scm>=8", "cython"]
3+
build-backend = "setuptools.build_meta"
4+
5+
[tool.setuptools_scm]

runviewer/__main__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,9 @@ def on_remove_shots(self, confirm=True):
697697
# unselect shot
698698
item.setCheckState(Qt.Unchecked)
699699
shutter_item.setCheckState(Qt.Unchecked)
700+
# remove shot from markers list
701+
shot_combobox_index = self.ui.markers_comboBox.findText(os.path.basename(shot.path))
702+
self.ui.markers_comboBox.removeItem(shot_combobox_index)
700703
# remove row
701704
self.shot_model.removeRow(row)
702705
del shot

runviewer/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import importlib_metadata
77

88
VERSION_SCHEME = {
9-
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "guess-next-dev"),
9+
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "release-branch-semver"),
1010
"local_scheme": os.getenv("SCM_LOCAL_SCHEME", "node-and-date"),
1111
}
1212

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from setuptools import setup
33

44
VERSION_SCHEME = {
5-
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "guess-next-dev"),
5+
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "release-branch-semver"),
66
"local_scheme": os.getenv("SCM_LOCAL_SCHEME", "node-and-date"),
77
}
88

0 commit comments

Comments
 (0)