Merge pull request #2 from mhr3/master

vishr · web-flow · commit 05b673bd85c6 · 2017-12-26T13:23:09.000-08:00
Fix context leak
diff --git a/session/session.go b/session/session.go
@@ -1,6 +1,7 @@
 package session
 
 import (
+	"github.com/gorilla/context"
 	"github.com/gorilla/sessions"
 	"github.com/labstack/echo"
 	"github.com/labstack/echo/middleware"
@@ -58,6 +59,7 @@ func MiddlewareWithConfig(config Config) echo.MiddlewareFunc {
 			if config.Skipper(c) {
 				return next(c)
 			}
+			defer context.Clear(c.Request())
 			c.Set(key, config.Store)
 			return next(c)
 		}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package session`
`2`	`2`
`3`	`3`	`import (`
	`4`	`+ "github.com/gorilla/context"`
`4`	`5`	`"github.com/gorilla/sessions"`
`5`	`6`	`"github.com/labstack/echo"`
`6`	`7`	`"github.com/labstack/echo/middleware"`
`@@ -58,6 +59,7 @@ func MiddlewareWithConfig(config Config) echo.MiddlewareFunc {`
`58`	`59`	`if config.Skipper(c) {`
`59`	`60`	`return next(c)`
`60`	`61`	`}`
	`62`	`+ defer context.Clear(c.Request())`
`61`	`63`	`c.Set(key, config.Store)`
`62`	`64`	`return next(c)`
`63`	`65`	`}`