Skip to content

Commit ef4aea9

Browse files
committed
use different variable name so returned function would not accidentally be able to use it in future and cause data race
1 parent 7c75310 commit ef4aea9

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

middleware/csrf.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ func CSRFWithConfig(config CSRFConfig) echo.MiddlewareFunc {
119119
config.CookieSecure = true
120120
}
121121

122-
extractors, err := CreateExtractors(config.TokenLookup)
123-
if err != nil {
124-
panic(err)
122+
extractors, cErr := CreateExtractors(config.TokenLookup)
123+
if cErr != nil {
124+
panic(cErr)
125125
}
126126

127127
return func(next echo.HandlerFunc) echo.HandlerFunc {

middleware/jwt.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ func JWTWithConfig(config JWTConfig) echo.MiddlewareFunc {
196196
config.ParseTokenFunc = config.defaultParseToken
197197
}
198198

199-
extractors, err := createExtractors(config.TokenLookup, config.AuthScheme)
200-
if err != nil {
201-
panic(err)
199+
extractors, cErr := createExtractors(config.TokenLookup, config.AuthScheme)
200+
if cErr != nil {
201+
panic(cErr)
202202
}
203203
if len(config.TokenLookupFuncs) > 0 {
204204
extractors = append(config.TokenLookupFuncs, extractors...)

middleware/key_auth.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ func KeyAuthWithConfig(config KeyAuthConfig) echo.MiddlewareFunc {
108108
panic("echo: key-auth middleware requires a validator function")
109109
}
110110

111-
extractors, err := createExtractors(config.KeyLookup, config.AuthScheme)
112-
if err != nil {
113-
panic(err)
111+
extractors, cErr := createExtractors(config.KeyLookup, config.AuthScheme)
112+
if cErr != nil {
113+
panic(cErr)
114114
}
115115

116116
return func(next echo.HandlerFunc) echo.HandlerFunc {

0 commit comments

Comments
 (0)