Skip to content

Commit caeed0b

Browse files
author
Timothy MacDonald
committed
refactor: updated graphic and removed report selection in the GUI
Removed GUI report selection due to pyside6 bug in QComboBox.setCurrentIndex() pending workaround Signed-off-by: Timothy MacDonald <[email protected]>
1 parent ab3ad29 commit caeed0b

File tree

7 files changed

+35
-23
lines changed

7 files changed

+35
-23
lines changed

Example-Report.pdf

698 KB
Binary file not shown.
318 KB
Loading

assets/mainwindow.ui

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,20 @@
4545
<layout class="QHBoxLayout" name="horizontalLayout_6">
4646
<item>
4747
<widget class="QLabel" name="labelSelectReport">
48+
<property name="enabled">
49+
<bool>false</bool>
50+
</property>
4851
<property name="text">
4952
<string>Select Report:</string>
5053
</property>
5154
</widget>
5255
</item>
5356
<item>
54-
<widget class="QComboBox" name="comboBoxReportSelector"/>
57+
<widget class="QComboBox" name="comboBoxReportSelector">
58+
<property name="editable">
59+
<bool>false</bool>
60+
</property>
61+
</widget>
5562
</item>
5663
<item>
5764
<spacer name="horizontalSpacer_4">

modules/gui_main.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,20 @@ def __init__(self, args, pre_processed_args, available_reports, basedir):
8282

8383
self.populate_fields_from_args()
8484
self.connect_ui_elements()
85+
86+
87+
# Hide report selector widget for now due to bug in setting combobox index, set report based on command line argument instead
88+
selected_report_name = [report['report_name'] for report in self.available_reports if report['report_short_name'] == self.args.report][0]
89+
self.report_changed(selected_report_name)
90+
self.window.labelSelectReport.hide()
91+
self.window.comboBoxReportSelector.hide()
92+
8593
self.window.show()
8694

8795

8896
def connect_ui_elements(self):
89-
self.window.comboBoxReportSelector.currentTextChanged.connect(self.report_changed)
97+
# Combobox disabled due to bug in setting current index
98+
# self.window.comboBoxReportSelector.currentTextChanged.connect(self.report_changed)
9099
self.window.pushButtonRunReport.clicked.connect(self.run_report)
91100
self.window.pushButtonTogglePreview.clicked.connect( self.toggle_preview)
92101
self.window.plainTextEditRecommendations.textChanged.connect(self.lineedits_changed)
@@ -159,17 +168,13 @@ def toggle_preview(self):
159168
self.report_preview.show()
160169

161170
def populate_fields_from_args(self):
162-
for available_report in self.available_reports:
163-
self.window.comboBoxReportSelector.addItem(available_report['report_name'])
164-
#print(str(self.args.report))
165-
selected_report_name = [report['report_name'] for report in self.available_reports if report['report_short_name'] == self.args.report][0]
166-
#print(selected_report_name)
167-
# Could not get comboBoxReportSelector.setCurrentIndex to work. Switching to setCurrentText
168-
report_index = self.window.comboBoxReportSelector.findText(str(selected_report_name))
169-
# print(report_index)
170-
# print(type(self.window.comboBoxReportSelector))
171-
self.window.comboBoxReportSelector.setCurrentIndex(report_index)
172-
#self.window.comboBoxReportSelector.setCurrentText(selected_report_name)
171+
# Combobox disabled due to bug in setting current index
172+
# for available_report in self.available_reports:
173+
# self.window.comboBoxReportSelector.addItem(available_report['report_name'])
174+
# selected_report_name = [report['report_name'] for report in self.available_reports if report['report_short_name'] == self.args.report][0]
175+
# report_index = self.window.comboBoxReportSelector.findText(str(selected_report_name))
176+
# self.window.comboBoxReportSelector.setCurrentIndex(report_index)
177+
173178

174179
if self.args.cache_data:
175180
self.window.checkBoxUseCache.setCheckState(Qt.Checked)

modules/reports/reportgen_csa_detailed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def __init__(self, basedir, use_cache=False, api_key_file=None, graph_scale=1):
2121
self.recommendations = self.default_recommendations
2222
self.template = self.get_jinja2_template('csa_detailed_report.jinja2')
2323
self.company_logo_html = self.file_to_image_tag('assets/Fortinet_logo.png', 'png')
24-
self.polygraph_graphic_html = self.file_to_image_tag('assets/FortiCNAPP-info.png', 'png')
24+
self.polygraph_graphic_html = self.file_to_image_tag('assets/FortiCNAPP-Unified-Approach.png', 'png')
2525

2626
def gather_data(self,
2727
vulns_start_time: LaceworkTime,

poetry.lock

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ logzero = "^1.7.0"
1919
pytest = "^7.2.1"
2020
python-dotenv = "^0.21.1"
2121
laceworksdk = "^4.1.0"
22-
pyside6 = "^6.4.3"
22+
pyside6 = "^6.9.0"
2323
weasyprint = "^62.1"
2424

2525

0 commit comments

Comments
 (0)